From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60660: Support git-formatted patches in diff-mode Date: Sun, 08 Jan 2023 20:51:22 +0200 Message-ID: <83h6x0q2qd.fsf@gnu.org> References: <86mt6ssx98.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17198"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60660@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 08 19:52:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEamS-0004GT-4c for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Jan 2023 19:52:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pEamC-0006kT-DL; Sun, 08 Jan 2023 13:52:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEam4-0006ib-B8 for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2023 13:52:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pEam2-00037X-7z for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2023 13:52:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pEam2-0005Hu-31 for bug-gnu-emacs@gnu.org; Sun, 08 Jan 2023 13:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Jan 2023 18:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60660 X-GNU-PR-Package: emacs Original-Received: via spool by 60660-submit@debbugs.gnu.org id=B60660.167320386720240 (code B ref 60660); Sun, 08 Jan 2023 18:52:02 +0000 Original-Received: (at 60660) by debbugs.gnu.org; 8 Jan 2023 18:51:07 +0000 Original-Received: from localhost ([127.0.0.1]:34719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEal8-0005GO-MA for submit@debbugs.gnu.org; Sun, 08 Jan 2023 13:51:06 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEal6-0005Ft-SO for 60660@debbugs.gnu.org; Sun, 08 Jan 2023 13:51:05 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEal1-0002M6-29; Sun, 08 Jan 2023 13:50:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=k5IWAe+aXe3YCbdD5ifq30anKOgjX4uLaSedq16f7wc=; b=bFUUwvK6RWhb DI7Vwwhh/nA+9baZbZAkRGceFc66v8/W5jaPQM7zUKVnmcr6qEM94hB3EiahfZmrhw30VXOpTfw3w 4DDEM4N/I5X7sMQoW/hIJe1E6nxM2doqVxOBDEhvMO4eZaa1jHSdpW/exrycY6udRFK5UCK7I5gHI vru1dxyG+e8Zb2mTHQ1l5pyC6+wSRFFDSfft1bXVWkjAMG/AMx9T+ZeopwkVY29mszaWEWMgTQ7Ay WrRPslNU2VljE4939j5ESmNOjVYcKW5pmtPhyKlJvFT3BuDML23fqZC+apSIVoLgEaIMtPIO9LzTe 00j7aHFT4mGxniWcmG7Uuw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEal0-0006K5-8d; Sun, 08 Jan 2023 13:50:58 -0500 In-Reply-To: <86mt6ssx98.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 08 Jan 2023 20:21:23 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252954 Archived-At: > From: Juri Linkov > Date: Sun, 08 Jan 2023 20:21:23 +0200 > > Currently, there is a lot of misfontification in diff-mode visiting a git patch. > Two dashes in the signature separator are highlighted with the diff-removed face > (the existing diff-prev-line-if-patch-separator is used for something else). > Three dashes in the git patch header that separate a list of affected files > are highlighted with the diff-hunk-header face, etc. > > But the worst case that raises an error is when an exclamation mark is used > at the beginning of the line in the git patch message. > > This patch for emacs-29 fixes this bug, and the rest of fontification > could be implemented in master. OK for the emacs-29 branch (although I'm surprised that diff-beginning-of-hunk can return a position that is not before point). Thanks.