From: Eli Zaretskii <eliz@gnu.org>
To: Gregory Heytings <gregory@heytings.org>
Cc: acohen@ust.hk, 64391@debbugs.gnu.org,
mattias.engdegard@gmail.com, monnier@iro.umontreal.ca
Subject: bug#64391: buffer narrowing slowdown regression in emacs 29
Date: Thu, 06 Jul 2023 21:22:07 +0300 [thread overview]
Message-ID: <83h6qghpdc.fsf@gnu.org> (raw)
In-Reply-To: <26cee506f70bbc9de58b@heytings.org> (message from Gregory Heytings on Thu, 06 Jul 2023 17:33:13 +0000)
> Date: Thu, 06 Jul 2023 17:33:13 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: acohen@ust.hk, 64391@debbugs.gnu.org, mattias.engdegard@gmail.com,
> monnier@iro.umontreal.ca
>
>
> I pushed a proposed change to the scratch/bug64391 branch.
>
> It contains three commits:
>
> - b741dc7fcd which is the minimal possible commit to fix this bug
>
> - 01fb898420 which moves a few statements from the callee
> (internal--label-restriction) to its only caller
> (internal--labeled-narrow-to-region), and simplifies the code accordingly
>
> - c52ade305e which is optional, and makes the symmetrical change for the
> widening case
>
> Eli and Mattias, could you perhaps have a look?
How are those different from what Mattias proposed? Is this a
completely different set of changes, or is it what Mattias suggested,
just in several separate parts?
If these are different, did you time the results in the use case(s)
where the slow-down was detected and reported, and compared the two
proposals performance-wise?
next prev parent reply other threads:[~2023-07-06 18:22 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-01 0:15 bug#64391: 30.0.50; buffer narrowing slowdown regression in emacs 29 Andrew Cohen
2023-07-01 2:45 ` bug#64391: bug 64391 wrong git info Andrew Cohen
2023-07-01 4:59 ` bug#64391: more info Andrew Cohen
2023-07-01 11:37 ` bug#64391: buffer narrowing slowdown regression in emacs 29 Mattias Engdegård
2023-07-01 12:08 ` Eli Zaretskii
2023-07-01 12:52 ` Mattias Engdegård
2023-07-02 7:35 ` Gregory Heytings
2023-07-05 11:57 ` Eli Zaretskii
2023-07-06 14:41 ` Gregory Heytings
2023-07-06 17:33 ` Gregory Heytings
2023-07-06 18:22 ` Eli Zaretskii [this message]
2023-07-06 18:45 ` Gregory Heytings
2023-07-07 9:30 ` Mattias Engdegård
2023-07-07 10:00 ` Gregory Heytings
2023-07-07 10:23 ` Eli Zaretskii
2023-07-07 10:31 ` Gregory Heytings
2023-07-07 12:41 ` Eli Zaretskii
2023-07-07 12:46 ` Gregory Heytings
2023-07-07 11:33 ` Mattias Engdegård
2023-07-07 12:42 ` Gregory Heytings
2023-07-07 15:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-08 20:58 ` Gregory Heytings
2023-07-08 21:42 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-08 22:21 ` Gregory Heytings
2023-07-08 23:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-09 16:03 ` Gregory Heytings
2023-07-09 18:57 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-09 6:03 ` Eli Zaretskii
2023-07-09 8:35 ` Gregory Heytings
2023-07-09 8:52 ` Eli Zaretskii
2023-07-09 16:04 ` Gregory Heytings
2023-07-09 16:39 ` Eli Zaretskii
2023-07-09 18:03 ` Gregory Heytings
2023-07-09 18:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-09 19:19 ` Gregory Heytings
2023-07-09 19:42 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-09 19:44 ` Gregory Heytings
2023-07-09 19:03 ` Eli Zaretskii
2023-07-09 19:06 ` Eli Zaretskii
2023-07-09 19:29 ` Gregory Heytings
2023-07-07 10:27 ` Eli Zaretskii
2023-07-07 11:27 ` Mattias Engdegård
2023-07-07 12:50 ` Eli Zaretskii
2023-07-07 16:49 ` Mattias Engdegård
2023-07-07 18:22 ` Eli Zaretskii
2023-07-08 8:01 ` Eli Zaretskii
2023-07-08 19:41 ` Gregory Heytings
2023-07-02 9:37 ` Mattias Engdegård
2023-07-01 7:07 ` bug#64391: 30.0.50; " Eli Zaretskii
2023-07-01 7:31 ` Andrew Cohen
2023-07-01 8:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h6qghpdc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=64391@debbugs.gnu.org \
--cc=acohen@ust.hk \
--cc=gregory@heytings.org \
--cc=mattias.engdegard@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).