From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64391: buffer narrowing slowdown regression in emacs 29 Date: Thu, 06 Jul 2023 21:22:07 +0300 Message-ID: <83h6qghpdc.fsf@gnu.org> References: <87r0psb51z.fsf@ust.hk> <0AD15A09-F669-48C0-AF5C-971D52F5BF8E@gmail.com> <83v8f3q1ff.fsf@gnu.org> <50A46AAC-2089-45CB-A355-CCB2B4EA8D76@gmail.com> <5995c9ed6a0b39c3070c@heytings.org> <83a5wak1tr.fsf@gnu.org> <26cee506f708f3c6cfe1@heytings.org> <26cee506f70bbc9de58b@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33570"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acohen@ust.hk, 64391@debbugs.gnu.org, mattias.engdegard@gmail.com, monnier@iro.umontreal.ca To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 06 20:23:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHTdV-0008X9-LT for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Jul 2023 20:23:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qHTdC-0004mK-3e; Thu, 06 Jul 2023 14:23:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHTd8-0004m1-Tv for bug-gnu-emacs@gnu.org; Thu, 06 Jul 2023 14:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qHTd8-00063O-JW for bug-gnu-emacs@gnu.org; Thu, 06 Jul 2023 14:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qHTd8-0005Mv-BK; Thu, 06 Jul 2023 14:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Thu, 06 Jul 2023 18:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64391 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 64391-submit@debbugs.gnu.org id=B64391.168866773520562 (code B ref 64391); Thu, 06 Jul 2023 18:23:02 +0000 Original-Received: (at 64391) by debbugs.gnu.org; 6 Jul 2023 18:22:15 +0000 Original-Received: from localhost ([127.0.0.1]:42024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHTcN-0005La-18 for submit@debbugs.gnu.org; Thu, 06 Jul 2023 14:22:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHTcK-0005LM-OI for 64391@debbugs.gnu.org; Thu, 06 Jul 2023 14:22:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHTcE-0005s7-RW; Thu, 06 Jul 2023 14:22:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jh3PZr3rFyeka8knz/g0SYN+11+6TQKHPYK43MKKNFE=; b=cTc+ibvH2mOC 1d7de9H28KWlOgpyCycbKaW4iNmn0qa01Um18sJ+17TbRutZZMufve3XdLs52Mf2c0ZX0VR4iROWm G9qC4YM/5AD/13iYbm8Z4WVkB41pFk15lejEXUghpNz65MRaLnU02rI02Cf58pDYFyeNr+cO8ElHq OjWBBtYGuYmuhTf3gDGM6Rlk/0uQbFLV4aAynBivUdBmunQldJrwg7lx3rCdeJY5Zqu3VwlkxK1Ly +nxiZe0h6WCeVsQ8qGA15CMgNLLNU2TTbf/DcWItbvgn4Otumar67fFngdMmyeqPxOSGb72AIV0XD Ld0/ymjxaKILb4YWskB4rg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHTcE-0008CT-An; Thu, 06 Jul 2023 14:22:06 -0400 In-Reply-To: <26cee506f70bbc9de58b@heytings.org> (message from Gregory Heytings on Thu, 06 Jul 2023 17:33:13 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264690 Archived-At: > Date: Thu, 06 Jul 2023 17:33:13 +0000 > From: Gregory Heytings > cc: acohen@ust.hk, 64391@debbugs.gnu.org, mattias.engdegard@gmail.com, > monnier@iro.umontreal.ca > > > I pushed a proposed change to the scratch/bug64391 branch. > > It contains three commits: > > - b741dc7fcd which is the minimal possible commit to fix this bug > > - 01fb898420 which moves a few statements from the callee > (internal--label-restriction) to its only caller > (internal--labeled-narrow-to-region), and simplifies the code accordingly > > - c52ade305e which is optional, and makes the symmetrical change for the > widening case > > Eli and Mattias, could you perhaps have a look? How are those different from what Mattias proposed? Is this a completely different set of changes, or is it what Mattias suggested, just in several separate parts? If these are different, did you time the results in the use case(s) where the slow-down was detected and reported, and compared the two proposals performance-wise?