unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Theodor Thornhill <theo@thornhill.no>
Cc: 59691@debbugs.gnu.org, casouri@gmail.com,
	jostein@secure.kjonigsen.net, jostein@kjonigsen.net
Subject: bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression
Date: Thu, 01 Dec 2022 09:44:49 +0200	[thread overview]
Message-ID: <83fsdzin4e.fsf@gnu.org> (raw)
In-Reply-To: <871qpj1x2k.fsf@thornhill.no> (message from Theodor Thornhill on Thu, 01 Dec 2022 07:01:55 +0100)

> From: Theodor Thornhill <theo@thornhill.no>
> Cc: casouri@gmail.com, jostein@secure.kjonigsen.net, 59691@debbugs.gnu.org,
>  jostein@kjonigsen.net
> Date: Thu, 01 Dec 2022 07:01:55 +0100
> 
> diff --git a/etc/NEWS b/etc/NEWS
> index 4e091a5fed..439d20960b 100644
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -2972,7 +2972,12 @@ A major mode based on the tree-sitter library for editing programs
>  in the TypeScript language.  It includes support for font-locking,
>  indentation, and navigation.
>  
> -** New major mode 'c-ts-mode'.
> +** New mode 'tsx-ts-mode'.
> +A major mode based on the tree-sitter library for editing programs
> +in the TypeScript language, with support for TSX.  It includes
> +support for font-locking, indentation, and navigation.
> +
> +** New mode 'c-ts-mode'.

Looks like some "git merge" snafu?  You are in fact reverting a change I
made in NEWS yesterday.

> diff --git a/lisp/progmodes/typescript-ts-mode.el b/lisp/progmodes/typescript-ts-mode.el
> index 6c926a4e3e..c1beaf3134 100644
> --- a/lisp/progmodes/typescript-ts-mode.el
> +++ b/lisp/progmodes/typescript-ts-mode.el

I don't see a change to auto-mode-alist to turn on each mode for the files
it supports?  I thought this was the idea?  Or is this because we don't want
tree-sitter based modes to be turned on by default?  In that case, how do we
explain to users that they should use each mode in the relevant cases?





  reply	other threads:[~2022-12-01  7:44 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-29 20:02 bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression Jostein Kjønigsen
2022-11-29 21:01 ` bug#59691: Html-like constructs fail in typescript Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-29 21:37   ` Jostein Kjønigsen
2022-11-29 21:47     ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]       ` <786DAB7F-F45D-405B-A4E5-4A60FD6CE7A7@secure.kjonigsen.net>
2022-11-30 12:59         ` Jostein Kjønigsen
2022-11-30 13:16           ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-30 12:35   ` Eli Zaretskii
2022-11-30 13:00     ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-30 14:25       ` Eli Zaretskii
2022-11-30 14:47         ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-30 10:22 ` bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression Yuan Fu
2022-11-30 14:09   ` Eli Zaretskii
2022-11-30 15:21     ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-30 16:05       ` Eli Zaretskii
2022-11-30 18:10         ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-30 18:19           ` Eli Zaretskii
2022-11-30 18:20             ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-30 18:21             ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-01  6:01               ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-01  7:44                 ` Eli Zaretskii [this message]
2022-12-01  8:12                   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-01 10:05                     ` Eli Zaretskii
2022-12-01 10:52                       ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-01 12:10                         ` Eli Zaretskii
2022-12-02  4:44                           ` Yuan Fu
2022-12-02 20:29                             ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-02 21:28                               ` Jostein Kjønigsen
2022-12-02 22:54                                 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-03  6:38                                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fsdzin4e.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=59691@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=jostein@kjonigsen.net \
    --cc=jostein@secure.kjonigsen.net \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).