From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression Date: Thu, 01 Dec 2022 09:44:49 +0200 Message-ID: <83fsdzin4e.fsf@gnu.org> References: <831qpklejb.fsf@gnu.org> <83mt88jul4.fsf@gnu.org> <0A18F996-F3BB-4A7D-A0BE-76C8374DE517@thornhill.no> <8335a0jofb.fsf@gnu.org> <7BE15945-C463-448A-8593-E3B5D0E374FB@thornhill.no> <871qpj1x2k.fsf@thornhill.no> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29948"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59691@debbugs.gnu.org, casouri@gmail.com, jostein@secure.kjonigsen.net, jostein@kjonigsen.net To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 01 08:46:46 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0eHN-0007a1-Sv for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Dec 2022 08:46:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0eH1-000511-2y; Thu, 01 Dec 2022 02:46:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0eGh-0004w8-Nu for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 02:46:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0eGg-0006D2-Eb for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 02:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0eGf-0005wG-Pk for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 02:46:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Dec 2022 07:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59691 X-GNU-PR-Package: emacs Original-Received: via spool by 59691-submit@debbugs.gnu.org id=B59691.166988073622821 (code B ref 59691); Thu, 01 Dec 2022 07:46:01 +0000 Original-Received: (at 59691) by debbugs.gnu.org; 1 Dec 2022 07:45:36 +0000 Original-Received: from localhost ([127.0.0.1]:38018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0eGG-0005w1-5c for submit@debbugs.gnu.org; Thu, 01 Dec 2022 02:45:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0eGD-0005vt-QP for 59691@debbugs.gnu.org; Thu, 01 Dec 2022 02:45:34 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0eG5-00066e-Ts; Thu, 01 Dec 2022 02:45:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BqVpaU9Ej7Ly30+5nJ6sOCju/0aZx2I2P6wUk10RgiU=; b=GePQGg5vKNZO xhX9BiuxARBkBgSy6jRrdT6WIR7PGLacGZYcxIR8xvpPn3VMoed5xN1ZbAMP7893s2FTzQJdiW3Oy ufDiEdwUie3Uify7wOX56ukvocecV3aMzE02+4n+U4zVOq8h+TqBZa2mC7+FuVAkjBSzTRckBYGkK U2dBkdz4PNj+FG4tSIGgKPefDfk+8zC2arnNt27b11HRHKEsMr2wUgSfQpOMj42UnVKDixuHzThjT ixt0wcMm0QHNyvQt/QARMknUzIza/Nr5lBhOhb7fQfCSbPgQHgo4yZ6DiY7rOPxlxi7Q4CDKosyyE mWX1J4L90QjW+7nadWp9rw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0eG2-0005dz-BJ; Thu, 01 Dec 2022 02:45:25 -0500 In-Reply-To: <871qpj1x2k.fsf@thornhill.no> (message from Theodor Thornhill on Thu, 01 Dec 2022 07:01:55 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249605 Archived-At: > From: Theodor Thornhill > Cc: casouri@gmail.com, jostein@secure.kjonigsen.net, 59691@debbugs.gnu.org, > jostein@kjonigsen.net > Date: Thu, 01 Dec 2022 07:01:55 +0100 > > diff --git a/etc/NEWS b/etc/NEWS > index 4e091a5fed..439d20960b 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -2972,7 +2972,12 @@ A major mode based on the tree-sitter library for editing programs > in the TypeScript language. It includes support for font-locking, > indentation, and navigation. > > -** New major mode 'c-ts-mode'. > +** New mode 'tsx-ts-mode'. > +A major mode based on the tree-sitter library for editing programs > +in the TypeScript language, with support for TSX. It includes > +support for font-locking, indentation, and navigation. > + > +** New mode 'c-ts-mode'. Looks like some "git merge" snafu? You are in fact reverting a change I made in NEWS yesterday. > diff --git a/lisp/progmodes/typescript-ts-mode.el b/lisp/progmodes/typescript-ts-mode.el > index 6c926a4e3e..c1beaf3134 100644 > --- a/lisp/progmodes/typescript-ts-mode.el > +++ b/lisp/progmodes/typescript-ts-mode.el I don't see a change to auto-mode-alist to turn on each mode for the files it supports? I thought this was the idea? Or is this because we don't want tree-sitter based modes to be turned on by default? In that case, how do we explain to users that they should use each mode in the relevant cases?