From: "Jostein Kjønigsen" <jostein@secure.kjonigsen.net>
To: Theodor Thornhill <theo@thornhill.no>
Cc: 59691@debbugs.gnu.org, casouri@gmail.com, jostein@kjonigsen.net,
eliz@gnu.org
Subject: bug#59691: Html-like constructs fail in typescript
Date: Tue, 29 Nov 2022 22:37:25 +0100 [thread overview]
Message-ID: <EC93A94C-846B-4A99-86F5-BEDD7B7C1658@secure.kjonigsen.net> (raw)
In-Reply-To: <87pmd58ohe.fsf@thornhill.no>
Nice!
Should we until further notice assume that js-ts-mode suffers from the same issues, and that a jsx-ts-mode might be needed too? To me it at least sounds plausible.
Speaking of duplication… Now that we have tree-sitter wouldn’t it be possible to use the same parser and/or the same major-modes for JS/JSX as we already do for TS/TSX? JS/JSX is just Typescript without the type-annotations, right?
Or are there good reasons for having separate modes for these?
—
Jostein Kjønigsen
https://jostein.kjønigsen.net
> On 29 Nov 2022, at 22:04, Theodor Thornhill <theo@thornhill.no> wrote:
>
>
> Hi Jostein!
>
> I already have a fix for this bug lined up, and will send the fix as
> soon as I get my other stuff applied. It relies on another patch that
> is waiting.
>
> The solution is to create two modes: typescript-ts-mode and
> tsx-ts-mode. They have separate parsers, and should be treated as
> separate languages. That means that in a .ts file we enable the
> 'typescript' language, and in .tsx we enable the 'tsx' language. This
> exact issue is why they have two languages.
>
> In other words, we cannot support this in typescript-ts-mode.
>
> I hope to get this in pretty soon :)
>
> Theo
next prev parent reply other threads:[~2022-11-29 21:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 20:02 bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression Jostein Kjønigsen
2022-11-29 21:01 ` bug#59691: Html-like constructs fail in typescript Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-29 21:37 ` Jostein Kjønigsen [this message]
2022-11-29 21:47 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <786DAB7F-F45D-405B-A4E5-4A60FD6CE7A7@secure.kjonigsen.net>
2022-11-30 12:59 ` Jostein Kjønigsen
2022-11-30 13:16 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-30 12:35 ` Eli Zaretskii
2022-11-30 13:00 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-30 14:25 ` Eli Zaretskii
2022-11-30 14:47 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-30 10:22 ` bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression Yuan Fu
2022-11-30 14:09 ` Eli Zaretskii
2022-11-30 15:21 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-30 16:05 ` Eli Zaretskii
2022-11-30 18:10 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-30 18:19 ` Eli Zaretskii
2022-11-30 18:20 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-30 18:21 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-01 6:01 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-01 7:44 ` Eli Zaretskii
2022-12-01 8:12 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-01 10:05 ` Eli Zaretskii
2022-12-01 10:52 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-01 12:10 ` Eli Zaretskii
2022-12-02 4:44 ` Yuan Fu
2022-12-02 20:29 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-02 21:28 ` Jostein Kjønigsen
2022-12-02 22:54 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-03 6:38 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EC93A94C-846B-4A99-86F5-BEDD7B7C1658@secure.kjonigsen.net \
--to=jostein@secure.kjonigsen.net \
--cc=59691@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=jostein@kjonigsen.net \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).