From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Date: Sat, 17 Apr 2021 22:30:08 +0300 Message-ID: <83eef8vhdr.fsf@gnu.org> References: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31139"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47784@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 17 21:31:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lXqer-0007zA-Tr for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Apr 2021 21:31:09 +0200 Original-Received: from localhost ([::1]:59470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXqer-0005N1-0l for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Apr 2021 15:31:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXqek-0005Mu-75 for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 15:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33130) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXqej-000122-Va for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 15:31:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lXqej-0000sM-Rf for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 15:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Apr 2021 19:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47784-submit@debbugs.gnu.org id=B47784.16186878303325 (code B ref 47784); Sat, 17 Apr 2021 19:31:01 +0000 Original-Received: (at 47784) by debbugs.gnu.org; 17 Apr 2021 19:30:30 +0000 Original-Received: from localhost ([127.0.0.1]:44676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXqeD-0000rZ-NI for submit@debbugs.gnu.org; Sat, 17 Apr 2021 15:30:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXqeC-0000rI-HS for 47784@debbugs.gnu.org; Sat, 17 Apr 2021 15:30:28 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38983) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXqe7-0000VH-7M; Sat, 17 Apr 2021 15:30:23 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3213 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lXqe5-00064X-JE; Sat, 17 Apr 2021 15:30:22 -0400 In-Reply-To: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> (message from Boruch Baum on Wed, 14 Apr 2021 23:31:47 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204259 Archived-At: > Date: Wed, 14 Apr 2021 23:31:47 -0400 > From: Boruch Baum > > Two patch files are attached. > > + ses-header-row.patch > > + Function `ses-set-header-row' was determining the current row based > upon variable `ses--curcell', but that variable is NIL until one > begins an operation on a cell (eg. keybindings '=', '"'), so > navigating to a row was insufficient to select that row, and further > generated an ERROR because the code was not expecting a NIL value for > variable `ses--curcell' > > + Using function `user-error' instead of `error' doesn't spawn a > debug session and backtrace buffer when variable > `toggle-debug-on-error' is set. > > + ses-user-error.patch > > + Quasi-randomly replaces some calls to function `error' with > `user-error'. > > + There could be many other desirable points of replacement, but these > were some obvious ones, and without knowing whether the patch would > be accepted at all, it's what I invested. Thanks, but I don't think I understand the rationale for the second patch. What is the problem with signaling an error in those two places?