bug#46773: 28.0.50; Different heights for toolbar

bug#46773: 28.0.50; Different heights for toolbar

[Lars Ingebrigtsen]

[-- Attachment #1: Type: text/plain, Size: 90 bytes --]


Starting from "emacs -Q":

C-h b

and choose the *Help* buffer.  You get this tool bar:


[-- Attachment #2: Type: image/png, Size: 3612 bytes --]

[-- Attachment #3: Type: text/plain, Size: 63 bytes --]


Switch back to the *scratch* buffer.  You get this tool bar:


[-- Attachment #4: Type: image/png, Size: 12630 bytes --]

[-- Attachment #5: Type: text/plain, Size: 658 bytes --]


Which is taller.  This means that the Emacs frame changes size every
time you pop between these two windows, which is highly annoying.

I guess it has something to do with the former toolbar not having any
text?


In GNU Emacs 28.0.50 (build 31, x86_64-pc-linux-gnu, GTK+ Version 3.24.23, cairo version 1.16.0)
 of 2021-02-22 built on xo
Repository revision: c1712f55070d1fe861517d2c1a9fe53622f0e6a6
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Debian GNU/Linux bullseye/sid


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#46773: 28.0.50; Different heights for toolbar

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Thu, 25 Feb 2021 16:30:02 +0100
> 
> Which is taller.  This means that the Emacs frame changes size every
> time you pop between these two windows, which is highly annoying.
> 
> I guess it has something to do with the former toolbar not having any
> text?

Yes.  And I think it's a GTK-only thing.

bug#46773: 28.0.50; Different heights for toolbar

[Robert Pluim]

>>>>> On Thu, 25 Feb 2021 17:37:24 +0200, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Lars Ingebrigtsen <larsi@gnus.org>
    >> Date: Thu, 25 Feb 2021 16:30:02 +0100
    >> 
    >> Which is taller.  This means that the Emacs frame changes size every
    >> time you pop between these two windows, which is highly annoying.
    >> 
    >> I guess it has something to do with the former toolbar not having any
    >> text?

    Eli> Yes.  And I think it's a GTK-only thing.

Didnʼt we vaguely agree that we should remove the text from the GTK
toolbar, as itʼs the only one that does it?

Robert
-- 

bug#46773: 28.0.50; Different heights for toolbar

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: Lars Ingebrigtsen <larsi@gnus.org>,  46773@debbugs.gnu.org
> Date: Thu, 25 Feb 2021 17:36:34 +0100
> 
>     >> I guess it has something to do with the former toolbar not having any
>     >> text?
> 
>     Eli> Yes.  And I think it's a GTK-only thing.
> 
> Didnʼt we vaguely agree that we should remove the text from the GTK
> toolbar, as itʼs the only one that does it?

If we did, I don't remember such an agreement.  Which doesn't mean it
didn't happen, of course.

bug#46773: 28.0.50; Different heights for toolbar

[Robert Pluim]

>>>>> On Thu, 25 Feb 2021 20:23:42 +0200, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Robert Pluim <rpluim@gmail.com>
    >> Cc: Lars Ingebrigtsen <larsi@gnus.org>,  46773@debbugs.gnu.org
    >> Date: Thu, 25 Feb 2021 17:36:34 +0100
    >> 
    >> >> I guess it has something to do with the former toolbar not having any
    >> >> text?
    >> 
    Eli> Yes.  And I think it's a GTK-only thing.
    >> 
    >> Didnʼt we vaguely agree that we should remove the text from the GTK
    >> toolbar, as itʼs the only one that does it?

    Eli> If we did, I don't remember such an agreement.  Which doesn't mean it
    Eli> didn't happen, of course.

It was a vague memory of a vague agreement, which I now canʼt find in
my archives. Perhaps we should do it anyway.

Robert
-- 

bug#46773: 28.0.50; Different heights for toolbar

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: 46773@debbugs.gnu.org,  larsi@gnus.org
> Date: Fri, 26 Feb 2021 10:13:37 +0100
> 
>     >> Didnʼt we vaguely agree that we should remove the text from the GTK
>     >> toolbar, as itʼs the only one that does it?
> 
>     Eli> If we did, I don't remember such an agreement.  Which doesn't mean it
>     Eli> didn't happen, of course.
> 
> It was a vague memory of a vague agreement, which I now canʼt find in
> my archives. Perhaps we should do it anyway.

I "vaguely" remember that Dmitry likes that, so let's hear his opinion
first.

bug#46773: 28.0.50; Different heights for toolbar

[Dmitry Gutov]

On 26.02.2021 14:03, Eli Zaretskii wrote:
> I "vaguely" remember that Dmitry likes that, so let's hear his opinion
> first.

Sure.

I'm no GTK expert, but a brief survey of other software shows that 
buttons these days usually have text or icon, never both (which is a 
waste of space). Some text could reside on the toolbar near the buttons, 
though (to describe a group of them).

FWIW, I can't reproduce the scenario in the report here, possibly 
because my text height is smaller than the icons, and Lars has it the 
opposite. High scale factor? GTK2 build?

bug#46773: [External] : bug#46773: 28.0.50; Different heights for toolbar

[Drew Adams]

> I'm no GTK expert, but a brief survey of other software shows that
> buttons these days usually have text or icon, never both (which is a
> waste of space).

"brief survey", yet "never".

I believe that MS Windows and its apps, and many
non-MS apps that run on Windows, let _users_
choose icons, text, or both.  I could be wrong,
but I don't think so.

If I'm right, does that count for you, for
"these days"?

bug#46773: [External] : bug#46773: 28.0.50; Different heights for toolbar

[Dmitry Gutov]

On 26.02.2021 18:08, Drew Adams wrote:
> I believe that MS Windows and its apps, and many
> non-MS apps that run on Windows, let_users_
> choose icons, text, or both.  I could be wrong,
> but I don't think so.

Evidence welcome.

> If I'm right, does that count for you, for
> "these days"?

Sure.

Even so, if the default behavior is as I said we should do that at least 
by default.

bug#46773: [External] : bug#46773: 28.0.50; Different heights for toolbar

[Robert Pluim]

>>>>> On Fri, 26 Feb 2021 18:23:05 +0200, Dmitry Gutov <dgutov@yandex.ru> said:

    Dmitry> On 26.02.2021 18:08, Drew Adams wrote:
    >> I believe that MS Windows and its apps, and many
    >> non-MS apps that run on Windows, let_users_
    >> choose icons, text, or both.  I could be wrong,
    >> but I don't think so.

    Dmitry> Evidence welcome.

    >> If I'm right, does that count for you, for
    >> "these days"?

    Dmitry> Sure.

    Dmitry> Even so, if the default behavior is as I said we should do that at
    Dmitry> least by default.

With an option to toggle from icon->icon+text? Sounds good to me
(although I haven't found yet why weʼre only showing text for some of
the icons under gtk).

Robert
-- 

bug#46773: [External] : bug#46773: 28.0.50; Different heights for toolbar

[Dmitry Gutov]

On 26.02.2021 19:02, Robert Pluim wrote:
> With an option to toggle from icon->icon+text? Sounds good to me
> (although I haven't found yet why weʼre only showing text for some of
> the icons under gtk).

Seems like someone sometime decided that "save" and "undo" need 
clarification (due to low-quality icons?), and others don't.

But for the above feature to work, I guess we'll need to annotate all of 
them. Well, at least the person working on adding that feature would.

bug#46773: [External] : bug#46773: 28.0.50; Different heights for toolbar

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: Drew Adams <drew.adams@oracle.com>,  Eli Zaretskii <eliz@gnu.org>,
>  <46773@debbugs.gnu.org>,  "larsi@gnus.org" <larsi@gnus.org>
> Date: Fri, 26 Feb 2021 18:02:58 +0100
> 
>     Dmitry> Even so, if the default behavior is as I said we should do that at
>     Dmitry> least by default.
> 
> With an option to toggle from icon->icon+text? Sounds good to me
> (although I haven't found yet why weʼre only showing text for some of
> the icons under gtk).

I think we still need to understand why sometimes the text is too
large, because the tool bar is not supposed to change its height.

Does someone know what determines the size of the font used for these
text labels?

bug#46773: 28.0.50; Different heights for toolbar

[Lars Ingebrigtsen]

Dmitry Gutov <dgutov@yandex.ru> writes:

> FWIW, I can't reproduce the scenario in the report here, possibly
> because my text height is smaller than the icons, and Lars has it the
> opposite. High scale factor? GTK2 build?

High scale factor.

The icons aren't scaled up, so they look rather awkward on HiDPI
screens.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#46773: 28.0.50; Different heights for toolbar

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Eli Zaretskii <eliz@gnu.org>,  Robert Pluim <rpluim@gmail.com>,
>   46773@debbugs.gnu.org
> Date: Sat, 27 Feb 2021 05:13:13 +0100
> 
> Dmitry Gutov <dgutov@yandex.ru> writes:
> 
> > FWIW, I can't reproduce the scenario in the report here, possibly
> > because my text height is smaller than the icons, and Lars has it the
> > opposite. High scale factor? GTK2 build?
> 
> High scale factor.
> 
> The icons aren't scaled up, so they look rather awkward on HiDPI
> screens.

So I guess until we teach Emacs to scale the icons, a user option to
disable the text labels should be a stopgap?

bug#46773: 28.0.50; Different heights for toolbar

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> So I guess until we teach Emacs to scale the icons, a user option to
> disable the text labels should be a stopgap?

Or...  see what the height of the default font is and use that as a
minimum height?  (I haven't actually looked at the code to see whether
there's a way to specify a min height.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#46773: 28.0.50; Different heights for toolbar

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: dgutov@yandex.ru,  rpluim@gmail.com,  46773@debbugs.gnu.org
> Date: Sat, 27 Feb 2021 12:52:17 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > So I guess until we teach Emacs to scale the icons, a user option to
> > disable the text labels should be a stopgap?
> 
> Or...  see what the height of the default font is and use that as a
> minimum height?

If we can do that, yes.  I assumed that the font used by the GTK tool
bar is not our default font, is it?  If it isn't, how can we know its
size?

bug#46773: 28.0.50; Different heights for toolbar

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> If we can do that, yes.  I assumed that the font used by the GTK tool
> bar is not our default font, is it?  If it isn't, how can we know its
> size?

Oh, yeah, I'd forgotten that we leave all that to the toolkit.  So
that's no good.  We could use heuristics -- that is, look at the default
font size and try to size up the min height based on that.  Not very
satisfactory, though.

This reminds me of bug#40978, which is about scaling images in toolbars
and the like based on the same heuristics as we do for in-buffer images
-- I was somewhat leery about going down that path because the
repercussions seem unpredictable, but that would probably have fixed
what I'm seeing in this bug report...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#46773: 28.0.50; Different heights for toolbar

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: 46773@debbugs.gnu.org,  rpluim@gmail.com,  dgutov@yandex.ru
> Date: Sun, 28 Feb 2021 14:36:03 +0100
> 
> Lars Ingebrigtsen <larsi@gnus.org> writes:
> 
> > This reminds me of bug#40978, which is about scaling images in toolbars
> > and the like based on the same heuristics as we do for in-buffer images
> > -- I was somewhat leery about going down that path because the
> > repercussions seem unpredictable, but that would probably have fixed
> > what I'm seeing in this bug report...
> 
> Or...  looking at that again, that's probably a completely separate
> issue, because the toolbar icons probably don't go though the Emacs
> image code at all, but all that stuff is left up to the toolkit, which
> is GTK3 in my instance?  (I'm looking at gtkutil.c...)

Yes, I think you are right.

So why does it work fore Dmitry?

bug#46773: 28.0.50; Different heights for toolbar

[Colin Baxter]

[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]

>>>>> Eli Zaretskii <eliz@gnu.org> writes:

    >> From: Lars Ingebrigtsen <larsi@gnus.org> Cc:
    >> 46773@debbugs.gnu.org, rpluim@gmail.com, dgutov@yandex.ru Date:
    >> Sun, 28 Feb 2021 14:36:03 +0100
    >> 
    >> Lars Ingebrigtsen <larsi@gnus.org> writes:
    >> 
    >> > This reminds me of bug#40978, which is about scaling images in
    >> toolbars > and the like based on the same heuristics as we do for
    >> in-buffer images > -- I was somewhat leery about going down that
    >> path because the > repercussions seem unpredictable, but that
    >> would probably have fixed > what I'm seeing in this bug report...
    >> 
    >> Or...  looking at that again, that's probably a completely
    >> separate issue, because the toolbar icons probably don't go
    >> though the Emacs image code at all, but all that stuff is left up
    >> to the toolkit, which is GTK3 in my instance?  (I'm looking at
    >> gtkutil.c...)

    > Yes, I think you are right.

    > So why does it work fore Dmitry?

Is this what's happening here? If you compile emacs-28 with tookit=lucid
and separately with the default (tookit=gtk3) and compare the two emacs
-q --geometry 83X37 you get different sizes. The gtk3 emacs is slightly
taller than the lucid version. I attach a screen shot. On the right is
lucid and on the left is gtk3. The tool bars are of slightly different
height.

I apologise if my intervention is a irrelevant.

Best wishes,



[-- Attachment #2: lucid-right-gtk3-left.png --]
[-- Type: image/png, Size: 147356 bytes --]

bug#46773: 28.0.50; Different heights for toolbar

[Lars Ingebrigtsen]

Colin Baxter <m43cap@yandex.com> writes:

> Is this what's happening here? If you compile emacs-28 with tookit=lucid
> and separately with the default (tookit=gtk3) and compare the two emacs
> -q --geometry 83X37 you get different sizes. The gtk3 emacs is slightly
> taller than the lucid version. I attach a screen shot. On the right is
> lucid and on the left is gtk3. The tool bars are of slightly different
> height.

My problem was apparently me having set the scaling for the fonts only
in Gnome Shell, and not the "overall" scaling, which also scales icons.

What you're seeing is pretty normal, I think -- different toolkits will
result in (slightly) different Emacs window sizes. 

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#46773: 28.0.50; Different heights for toolbar

[Colin Baxter]

>>>>> Lars Ingebrigtsen <larsi@gnus.org> writes:

    > Colin Baxter <m43cap@yandex.com> writes:
    >> Is this what's happening here? If you compile emacs-28 with
    >> tookit=lucid and separately with the default (tookit=gtk3) and
    >> compare the two emacs -q --geometry 83X37 you get different
    >> sizes. The gtk3 emacs is slightly taller than the lucid
    >> version. I attach a screen shot. On the right is lucid and on the
    >> left is gtk3. The tool bars are of slightly different height.

    > My problem was apparently me having set the scaling for the fonts
    > only in Gnome Shell, and not the "overall" scaling, which also
    > scales icons.

    > What you're seeing is pretty normal, I think -- different toolkits
    > will result in (slightly) different Emacs window sizes.

Ok, thanks.

Best wishes,

bug#46773: 28.0.50; Different heights for toolbar

[Dmitry Gutov]

On 27.02.2021 06:13, Lars Ingebrigtsen wrote:
>> FWIW, I can't reproduce the scenario in the report here, possibly
>> because my text height is smaller than the icons, and Lars has it the
>> opposite. High scale factor? GTK2 build?
> High scale factor.
> 
> The icons aren't scaled up, so they look rather awkward on HiDPI
> screens.

Is that with a GTK2 build, then?

My scale factor is 2x, and icons are scaled proportionally on GTK3.

bug#46773: 28.0.50; Different heights for toolbar

[Dmitry Gutov]

On 28.02.2021 15:31, Lars Ingebrigtsen wrote:
> My Emacs says:
> 
> In GNU Emacs 28.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0)
> 
> So that's GTK3, I guess?

Seems so. (string-match-p "GTK3" system-configuration-features) should 
tell more reliably, though.

Perhaps you icon theme doesn't provide scaled versions of the icons 
(mine includes .svg files for scaling) and GTK decided that it shouldn't 
scale the icons because of that.

Just guessing, though. I tried a bunch of icons themes already installed 
on my machine and couldn't repro, but they probably all do provide 
scaled versions of the respective icons.

And my GTK version is 3.24.20. Same Cairo version.

bug#46773: 28.0.50; Different heights for toolbar

[Lars Ingebrigtsen]

[-- Attachment #1: Type: text/plain, Size: 717 bytes --]

Dmitry Gutov <dgutov@yandex.ru> writes:

> Seems so. (string-match-p "GTK3" system-configuration-features) should
> tell more reliably, though.

(string-match-p "GTK3" system-configuration-features)
=> 225

> Perhaps you icon theme doesn't provide scaled versions of the icons
> (mine includes .svg files for scaling) and GTK decided that it
> shouldn't scale the icons because of that.
>
> Just guessing, though. I tried a bunch of icons themes already
> installed on my machine and couldn't repro, but they probably all do
> provide scaled versions of the respective icons.
>
> And my GTK version is 3.24.20. Same Cairo version.

My toolbar looks totally different from all the other screenshots,
though.  I mean:


[-- Attachment #2: Type: image/png, Size: 19822 bytes --]

[-- Attachment #3: Type: text/plain, Size: 306 bytes --]


I'm using a dark mode, but is that (and the lack of scaling of the
icons) the only difference?

Is it possible that Gnome Shell (or something) is somehow interfering
here and substituting other icons?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#46773: 28.0.50; Different heights for toolbar

[Lars Ingebrigtsen]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Is it possible that Gnome Shell (or something) is somehow interfering
> here and substituting other icons?

D'oh!

All this is just user error on my part.  I had changed the font scaling
in gnome-tweaks to x2.7, and not done any proper scaling.

Now, with a 200% scaling (and a x1.3 font scaling), I get:


[-- Attachment #2: Type: image/png, Size: 17226 bytes --]

[-- Attachment #3: Type: text/plain, Size: 276 bytes --]


Which is more reasonable, and the toolbar no longer changes height.

So I don't think there's anything to fix here, and I'm closing this bug
report.

Sorry for the noise.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no