unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Gabriel do Nascimento Ribeiro <gabriel376@hotmail.com>
Cc: 45946@debbugs.gnu.org
Subject: bug#45946: [PATCH] Re: bug#45946: 28.0.50; hl-line-sticky-flag not working
Date: Thu, 21 Jan 2021 16:13:52 +0200	[thread overview]
Message-ID: <83bldi74yn.fsf@gnu.org> (raw)
In-Reply-To: <CH2PR01MB58793D2A9A2B87E02C7875988BA10@CH2PR01MB5879.prod.exchangelabs.com> (message from Gabriel do Nascimento Ribeiro on Wed, 20 Jan 2021 22:07:33 -0300)

> From: Gabriel do Nascimento Ribeiro <gabriel376@hotmail.com>
> Date: Wed, 20 Jan 2021 22:07:33 -0300
> 
> Here is a proposal of patch for this bug. It seems to work well in all
> cases I have tested, but maybe I am missing some edge case. Suggestions
> are welcome.

Thanks.

While at that, would it be possible to fix some code there that I at
least consider strange?  E.g., it calls delete-overlay, but doesn't
assign nil to the variable, so the overlayp predicate still returns
non-nil for the resulting invalid overlay.  Also, it puts 2 functions
on the post-command-hook, but it looks like the code subtly depends on
the order of their execution (should hl-line-highlight run before or
after hl-line-maybe-unhighlight?).





  reply	other threads:[~2021-01-21 14:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18  4:13 bug#45946: 28.0.50; hl-line-sticky-flag not working Gabriel do Nascimento Ribeiro
2021-01-21  1:07 ` bug#45946: [PATCH] " Gabriel do Nascimento Ribeiro
2021-01-21 14:13   ` Eli Zaretskii [this message]
2021-01-23  2:22     ` Gabriel do Nascimento Ribeiro
2021-01-23  8:10       ` Eli Zaretskii
2021-01-23 19:11         ` Gabriel do Nascimento Ribeiro
2021-01-23 19:37           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bldi74yn.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=45946@debbugs.gnu.org \
    --cc=gabriel376@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).