From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#45946: [PATCH] Re: bug#45946: 28.0.50; hl-line-sticky-flag not working Date: Thu, 21 Jan 2021 16:13:52 +0200 Message-ID: <83bldi74yn.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33660"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45946@debbugs.gnu.org To: Gabriel do Nascimento Ribeiro Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 21 15:14:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2aiv-0008bM-BL for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Jan 2021 15:14:09 +0100 Original-Received: from localhost ([::1]:54236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2aiu-0006rS-DN for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Jan 2021 09:14:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2aio-0006rD-Pw for bug-gnu-emacs@gnu.org; Thu, 21 Jan 2021 09:14:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45626) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l2aio-00062X-Ij for bug-gnu-emacs@gnu.org; Thu, 21 Jan 2021 09:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l2aio-0004Aa-Ej for bug-gnu-emacs@gnu.org; Thu, 21 Jan 2021 09:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Jan 2021 14:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45946 X-GNU-PR-Package: emacs Original-Received: via spool by 45946-submit@debbugs.gnu.org id=B45946.161123842515992 (code B ref 45946); Thu, 21 Jan 2021 14:14:02 +0000 Original-Received: (at 45946) by debbugs.gnu.org; 21 Jan 2021 14:13:45 +0000 Original-Received: from localhost ([127.0.0.1]:57172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2aiX-00049s-9c for submit@debbugs.gnu.org; Thu, 21 Jan 2021 09:13:45 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2aiV-00049c-Oy for 45946@debbugs.gnu.org; Thu, 21 Jan 2021 09:13:43 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42233) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2aiQ-0005rz-Hh; Thu, 21 Jan 2021 09:13:38 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1782 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l2aiP-0006f3-9Y; Thu, 21 Jan 2021 09:13:37 -0500 In-Reply-To: (message from Gabriel do Nascimento Ribeiro on Wed, 20 Jan 2021 22:07:33 -0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198310 Archived-At: > From: Gabriel do Nascimento Ribeiro > Date: Wed, 20 Jan 2021 22:07:33 -0300 > > Here is a proposal of patch for this bug. It seems to work well in all > cases I have tested, but maybe I am missing some edge case. Suggestions > are welcome. Thanks. While at that, would it be possible to fix some code there that I at least consider strange? E.g., it calls delete-overlay, but doesn't assign nil to the variable, so the overlayp predicate still returns non-nil for the resulting invalid overlay. Also, it puts 2 functions on the post-command-hook, but it looks like the code subtly depends on the order of their execution (should hl-line-highlight run before or after hl-line-maybe-unhighlight?).