unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Gabriel do Nascimento Ribeiro <gabriel376@hotmail.com>
Cc: 45946@debbugs.gnu.org
Subject: bug#45946: [PATCH] Re: bug#45946: 28.0.50; hl-line-sticky-flag not working
Date: Sat, 23 Jan 2021 10:10:47 +0200	[thread overview]
Message-ID: <8335ys5b08.fsf@gnu.org> (raw)
In-Reply-To: <CH2PR01MB5879621844ECA37EF863B1198BBF0@CH2PR01MB5879.prod.exchangelabs.com> (message from Gabriel do Nascimento Ribeiro on Fri, 22 Jan 2021 23:22:21 -0300)

> From: Gabriel do Nascimento Ribeiro <gabriel376@hotmail.com>
> Date: Fri, 22 Jan 2021 23:22:21 -0300
> 
> > While at that, would it be possible to fix some code there that I at
> > least consider strange?  E.g., it calls delete-overlay, but doesn't
> > assign nil to the variable, so the overlayp predicate still returns
> > non-nil for the resulting invalid overlay.  Also, it puts 2 functions
> > on the post-command-hook, but it looks like the code subtly depends on
> > the order of their execution (should hl-line-highlight run before or
> > after hl-line-maybe-unhighlight?).
> 
> Hi Eli,
> 
> Thanks for your suggestions. Please find attached a new patch that uses
> a single post-command-hook function and some other minor changes. The
> original issue is fixed.

Thanks, this LGTM, but could you please accompany the changes with the
ChangeLog-style commit log message (see CONTRIBUTE about the details)?

Also, this patch is close to the limit that we can accept without
copyright assignment.  So I'd suggest that you start the legal
paperwork rolling at this time, to allow us to accept your future
contributions.  Would you like me to send to you the legal form to
fill?





  reply	other threads:[~2021-01-23  8:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18  4:13 bug#45946: 28.0.50; hl-line-sticky-flag not working Gabriel do Nascimento Ribeiro
2021-01-21  1:07 ` bug#45946: [PATCH] " Gabriel do Nascimento Ribeiro
2021-01-21 14:13   ` Eli Zaretskii
2021-01-23  2:22     ` Gabriel do Nascimento Ribeiro
2021-01-23  8:10       ` Eli Zaretskii [this message]
2021-01-23 19:11         ` Gabriel do Nascimento Ribeiro
2021-01-23 19:37           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8335ys5b08.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=45946@debbugs.gnu.org \
    --cc=gabriel376@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).