From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 58877@debbugs.gnu.org
Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt
Date: Sun, 30 Oct 2022 08:14:44 +0200 [thread overview]
Message-ID: <83a65dhm7f.fsf@gnu.org> (raw)
In-Reply-To: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> (message from Jim Porter on Sat, 29 Oct 2022 14:33:42 -0700)
> Date: Sat, 29 Oct 2022 14:33:42 -0700
> From: Jim Porter <jporterbugs@gmail.com>
>
> Attached is a patch to do this. Note that I named the new argument
> "noframe" because that matches the existing code in server.el (see
> 'server-delete-client'). It's a bit of a misnomer though, and maybe
> "keep-frames" would be better...
Hmm... it doesn't look very elegant to add to server-start an extra
argument whose purpose is to affect server-delete-client. Can we do
this in some more elegant way? For example, how about making most of
the code in server-start an internal function with an additional
argument, and then have server-start and server-force-stop call that
internal function? At the very least the new argument to server-start
shouldn't be advertised, I think, since it's entirely for internal use
by us.
Thanks.
next prev parent reply other threads:[~2022-10-30 6:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-29 21:33 bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Jim Porter
2022-10-30 6:14 ` Eli Zaretskii [this message]
2022-10-30 21:14 ` Jim Porter
2022-11-22 5:06 ` Jim Porter
2022-11-24 11:51 ` Eli Zaretskii
2022-11-25 1:36 ` Jim Porter
2022-11-25 13:25 ` Eli Zaretskii
2022-11-25 19:31 ` Jim Porter
2022-11-25 20:18 ` Eli Zaretskii
2022-11-25 20:57 ` Jim Porter
2022-11-26 14:43 ` Eli Zaretskii
2022-11-26 19:04 ` Jim Porter
2022-11-26 19:45 ` Eli Zaretskii
2022-11-26 20:17 ` Jim Porter
2022-11-26 20:35 ` Eli Zaretskii
2022-11-26 21:44 ` Jim Porter
2022-11-28 1:28 ` Jim Porter
2022-11-28 3:31 ` Eli Zaretskii
2022-11-28 6:27 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a65dhm7f.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=58877@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).