From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Date: Sun, 30 Oct 2022 08:14:44 +0200 Message-ID: <83a65dhm7f.fsf@gnu.org> References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21520"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58877@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 30 07:16:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1op1cT-0005Tg-14 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Oct 2022 07:16:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1op1c9-0002gT-VT; Sun, 30 Oct 2022 02:16:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op1c3-0002ab-EZ for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 02:16:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1op1c2-0005bT-Hm for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 02:16:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1op1c2-0007S0-6B for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 02:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Oct 2022 06:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.166711051128573 (code B ref 58877); Sun, 30 Oct 2022 06:16:02 +0000 Original-Received: (at 58877) by debbugs.gnu.org; 30 Oct 2022 06:15:11 +0000 Original-Received: from localhost ([127.0.0.1]:37157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1op1bD-0007Qm-85 for submit@debbugs.gnu.org; Sun, 30 Oct 2022 02:15:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1op1bB-0007QV-0u for 58877@debbugs.gnu.org; Sun, 30 Oct 2022 02:15:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op1b5-0005GG-N3; Sun, 30 Oct 2022 02:15:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ANpmIS4GP0IQ91wFU235CurnmR5oyPWCRe5L6e+zQq0=; b=YBc33OhJnqZG 9Auqw+58wrbq0aYqNU/isv3f4GwOe8eUFx4MmLyDSgfh/LJFksasLp1h3ZnoKXQEj4zbgX4JCCcbF zFEpPJm9aXf+CBPVjQfpa3fvSLmk76GJFgofHFmN67/TzU1bMzI97X8iCZ63+EbmalGzw9hri0LlN SoeyZx1Hoj48QNE1Bq+kVvuC1m5isLqXb2bfyU056L+g7wQN/tkjSquuIw47nX3FOc/L0nxbRqnkk S+GkAIFEQKwDpjlPmBrGnFf/mVTRQj4vCh75O0U9Da5TxDfObXQPPxAdXrqmA1mJffAKQPZyljTl0 WUZMJeEFzx1JYGQ8mDs/3A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op1b5-0005cb-1o; Sun, 30 Oct 2022 02:15:03 -0400 In-Reply-To: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> (message from Jim Porter on Sat, 29 Oct 2022 14:33:42 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246585 Archived-At: > Date: Sat, 29 Oct 2022 14:33:42 -0700 > From: Jim Porter > > Attached is a patch to do this. Note that I named the new argument > "noframe" because that matches the existing code in server.el (see > 'server-delete-client'). It's a bit of a misnomer though, and maybe > "keep-frames" would be better... Hmm... it doesn't look very elegant to add to server-start an extra argument whose purpose is to affect server-delete-client. Can we do this in some more elegant way? For example, how about making most of the code in server-start an internal function with an additional argument, and then have server-start and server-force-stop call that internal function? At the very least the new argument to server-start shouldn't be advertised, I think, since it's entirely for internal use by us. Thanks.