unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 58877@debbugs.gnu.org
Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt
Date: Fri, 25 Nov 2022 22:18:56 +0200	[thread overview]
Message-ID: <83wn7iu6rz.fsf@gnu.org> (raw)
In-Reply-To: <f8a7cd24-3cb2-ac62-eb0f-928946619bda@gmail.com> (message from Jim Porter on Fri, 25 Nov 2022 11:31:07 -0800)

> Date: Fri, 25 Nov 2022 11:31:07 -0800
> Cc: 58877@debbugs.gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
> 
> Hm, it looks like the emacsclient may not be starting up correctly. 
> Could you try the attached patch? I doubt this will fix the tests, but 
> hopefully you'll get some more-useful error messages.

Here are the failure info from each failed test after this patch:

Test server-tests/emacsclient/create-frame condition:
    Output:
    (ert-test-failed "timed out waiting for (or (= (length server-clients) (1+ starting-client-count)) (eq (process-status emacsclient) exit-status)) to be non-nil")
   FAILED  1/7  server-tests/emacsclient/create-frame (5.062500 sec) at lisp/server-tests.el:138

Test server-tests/emacsclient/eval condition:
    Output:
    (wrong-type-argument number-or-marker-p nil)
   FAILED  2/7  server-tests/emacsclient/eval (0.109375 sec) at lisp/server-tests.el:150

Test server-tests/emacsclient/server-edit condition:
    Output:
    (ert-test-failed "timed out waiting for (get-buffer \"file.txt\") to be non-nil")
   FAILED  3/7  server-tests/emacsclient/server-edit (5.156250 sec) at lisp/server-tests.el:129

Test server-tests/server-force-stop/keeps-frames condition:
    Output:
    (ert-test-failed
     ((should
       (eq
        (process-status emacsclient)
        'run))
      :form
      (eq exit run)
      :value nil))
   FAILED  4/7  server-tests/server-force-stop/keeps-frames (0.109375 sec) at lisp/server-tests.el:159

Test server-tests/server-start/stop-prompt-with-client condition:
    Output:
    (ert-test-failed
     ((should
       (length=
        (frame-list)
        2))
      :form
      (length=
       (#<frame F1 06d263c0>)
       2)
      :value nil))
   FAILED  7/7  server-tests/server-start/stop-prompt-with-client (0.125000 sec) at lisp/server-tests.el:106





  reply	other threads:[~2022-11-25 20:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-29 21:33 bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Jim Porter
2022-10-30  6:14 ` Eli Zaretskii
2022-10-30 21:14   ` Jim Porter
2022-11-22  5:06     ` Jim Porter
2022-11-24 11:51       ` Eli Zaretskii
2022-11-25  1:36         ` Jim Porter
2022-11-25 13:25           ` Eli Zaretskii
2022-11-25 19:31             ` Jim Porter
2022-11-25 20:18               ` Eli Zaretskii [this message]
2022-11-25 20:57                 ` Jim Porter
2022-11-26 14:43                   ` Eli Zaretskii
2022-11-26 19:04                     ` Jim Porter
2022-11-26 19:45                       ` Eli Zaretskii
2022-11-26 20:17                         ` Jim Porter
2022-11-26 20:35                           ` Eli Zaretskii
2022-11-26 21:44                             ` Jim Porter
2022-11-28  1:28                               ` Jim Porter
2022-11-28  3:31                                 ` Eli Zaretskii
2022-11-28  6:27                                   ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wn7iu6rz.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=58877@debbugs.gnu.org \
    --cc=jporterbugs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).