From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: sbaugh@janestreet.com, 66668@debbugs.gnu.org
Subject: bug#66668: [PATCH] Teach ffap to look for paths under the root of project
Date: Sun, 29 Oct 2023 14:56:32 +0200 [thread overview]
Message-ID: <83a5s1bn9b.fsf@gnu.org> (raw)
In-Reply-To: <271bf6ef-4470-69f7-0892-ee7c95d56fe2@gutov.dev> (message from Dmitry Gutov on Sun, 29 Oct 2023 14:43:32 +0200)
> Date: Sun, 29 Oct 2023 14:43:32 +0200
> Cc: 66668@debbugs.gnu.org
> From: Dmitry Gutov <dmitry@gutov.dev>
>
> On 29/10/2023 14:23, Eli Zaretskii wrote:
> >> From: Spencer Baugh<sbaugh@janestreet.com>
> >> Cc:dmitry@gutov.dev,66668@debbugs.gnu.org
> >> Date: Wed, 25 Oct 2023 11:08:12 -0400
> >>
> >> Eli Zaretskii<eliz@gnu.org> writes:
> >>>> Cc: Dmitry Gutov<dmitry@gutov.dev>
> >>>> From: Spencer Baugh<sbaugh@janestreet.com>
> >>>> Date: Sat, 21 Oct 2023 14:37:45 -0400
> >>>>
> >>>> Subject: [PATCH] Teach ffap to look for paths under the root of project
> >>> Please don't use "path" when you mean "file name". The GNU Coding
> >>> Standards frown on such uses of "path".
> >> Oops, fixed.
> >>
> >> (Also fixed a byte-compiler warning from not declaring project-root)
> > Dmitry, any comments?
>
> If the way it works is useful for people (probably will be), I'm good
> with it.
>
> Ideally, it possibly would check whether the file belongs to the
> project-files fileset, but that's going to be slower, and thus probably
> not worth the marginal improvement.
Then I guess we should install this?
next prev parent reply other threads:[~2023-10-29 12:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-21 18:37 bug#66668: [PATCH] Teach ffap to look for paths under the root of project Spencer Baugh
2023-10-21 19:06 ` Eli Zaretskii
2023-10-25 15:08 ` Spencer Baugh
2023-10-29 12:23 ` Eli Zaretskii
2023-10-29 12:43 ` Dmitry Gutov
2023-10-29 12:56 ` Eli Zaretskii [this message]
2023-10-30 0:59 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a5s1bn9b.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=66668@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).