From: Dmitry Gutov <dmitry@gutov.dev>
To: Eli Zaretskii <eliz@gnu.org>
Cc: sbaugh@janestreet.com, 66668-done@debbugs.gnu.org
Subject: bug#66668: [PATCH] Teach ffap to look for paths under the root of project
Date: Mon, 30 Oct 2023 02:59:28 +0200 [thread overview]
Message-ID: <c73a4fdb-0b8f-3400-031b-03d4d9fe8d8e@gutov.dev> (raw)
In-Reply-To: <83a5s1bn9b.fsf@gnu.org>
Version: 30.1
On 29/10/2023 14:56, Eli Zaretskii wrote:
>> Date: Sun, 29 Oct 2023 14:43:32 +0200
>> Cc: 66668@debbugs.gnu.org
>> From: Dmitry Gutov <dmitry@gutov.dev>
>>
>> On 29/10/2023 14:23, Eli Zaretskii wrote:
>>>> From: Spencer Baugh<sbaugh@janestreet.com>
>>>> Cc:dmitry@gutov.dev,66668@debbugs.gnu.org
>>>> Date: Wed, 25 Oct 2023 11:08:12 -0400
>>>>
>>>> Eli Zaretskii<eliz@gnu.org> writes:
>>>>>> Cc: Dmitry Gutov<dmitry@gutov.dev>
>>>>>> From: Spencer Baugh<sbaugh@janestreet.com>
>>>>>> Date: Sat, 21 Oct 2023 14:37:45 -0400
>>>>>>
>>>>>> Subject: [PATCH] Teach ffap to look for paths under the root of project
>>>>> Please don't use "path" when you mean "file name". The GNU Coding
>>>>> Standards frown on such uses of "path".
>>>> Oops, fixed.
>>>>
>>>> (Also fixed a byte-compiler warning from not declaring project-root)
>>> Dmitry, any comments?
>>
>> If the way it works is useful for people (probably will be), I'm good
>> with it.
>>
>> Ideally, it possibly would check whether the file belongs to the
>> project-files fileset, but that's going to be slower, and thus probably
>> not worth the marginal improvement.
>
> Then I guess we should install this?
Sure, installed.
Thanks, and closing!
prev parent reply other threads:[~2023-10-30 0:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-21 18:37 bug#66668: [PATCH] Teach ffap to look for paths under the root of project Spencer Baugh
2023-10-21 19:06 ` Eli Zaretskii
2023-10-25 15:08 ` Spencer Baugh
2023-10-29 12:23 ` Eli Zaretskii
2023-10-29 12:43 ` Dmitry Gutov
2023-10-29 12:56 ` Eli Zaretskii
2023-10-30 0:59 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c73a4fdb-0b8f-3400-031b-03d4d9fe8d8e@gutov.dev \
--to=dmitry@gutov.dev \
--cc=66668-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).