From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66668: [PATCH] Teach ffap to look for paths under the root of project Date: Sun, 29 Oct 2023 14:56:32 +0200 Message-ID: <83a5s1bn9b.fsf@gnu.org> References: <838r7vre1a.fsf@gnu.org> <83edhdborx.fsf@gnu.org> <271bf6ef-4470-69f7-0892-ee7c95d56fe2@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15966"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@janestreet.com, 66668@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 29 14:03:48 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qx5SG-0003wA-9K for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Oct 2023 14:03:48 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qx5MG-0003zA-3Q; Sun, 29 Oct 2023 08:57:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qx5MA-0003yf-T2 for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 08:57:32 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qx5M9-0005tF-OP for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 08:57:29 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qx5Mg-0001qn-7v for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 08:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Oct 2023 12:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66668 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66668-submit@debbugs.gnu.org id=B66668.16985842577076 (code B ref 66668); Sun, 29 Oct 2023 12:58:02 +0000 Original-Received: (at 66668) by debbugs.gnu.org; 29 Oct 2023 12:57:37 +0000 Original-Received: from localhost ([127.0.0.1]:40698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qx5MH-0001q4-Aj for submit@debbugs.gnu.org; Sun, 29 Oct 2023 08:57:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qx5MC-0001pk-Pq for 66668@debbugs.gnu.org; Sun, 29 Oct 2023 08:57:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qx5LZ-0005po-C3; Sun, 29 Oct 2023 08:56:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KuwWwxZgD0c/zznWPhqcQ0VrLAvixDT1E1zFigbGWG4=; b=VUcaJMSTXoXu +icNkMMhmSUle2HbjWcOEBNtLh+59MT2hLon/5nHgUFmxg9t0kY1AirA7UHiSXFFwHyu9zQDr5J6q QZGuhP4hM1aAxrs7lynDeTqasoBDPDgr58IgQCQQDdAoKmILQQ3+OG7u9wOOxz5Df0DILnhO8lyxk qzizOm05BE/s8iz05NQifR+dRAt5k/tHZoLIborAbh3PS86X6rzpiiYUzOx5mb6hjzularN5XtsNt KTzEJp3/v5tala1CvolgGl4xpl+26qzN9Bqfl6Oao+SV+/A8j4mgRKFg5hdVo72dZQJJRDXbK/80H +jRqQFD6GeQWYr1GxiUo3g==; In-Reply-To: <271bf6ef-4470-69f7-0892-ee7c95d56fe2@gutov.dev> (message from Dmitry Gutov on Sun, 29 Oct 2023 14:43:32 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273506 Archived-At: > Date: Sun, 29 Oct 2023 14:43:32 +0200 > Cc: 66668@debbugs.gnu.org > From: Dmitry Gutov > > On 29/10/2023 14:23, Eli Zaretskii wrote: > >> From: Spencer Baugh > >> Cc:dmitry@gutov.dev,66668@debbugs.gnu.org > >> Date: Wed, 25 Oct 2023 11:08:12 -0400 > >> > >> Eli Zaretskii writes: > >>>> Cc: Dmitry Gutov > >>>> From: Spencer Baugh > >>>> Date: Sat, 21 Oct 2023 14:37:45 -0400 > >>>> > >>>> Subject: [PATCH] Teach ffap to look for paths under the root of project > >>> Please don't use "path" when you mean "file name". The GNU Coding > >>> Standards frown on such uses of "path". > >> Oops, fixed. > >> > >> (Also fixed a byte-compiler warning from not declaring project-root) > > Dmitry, any comments? > > If the way it works is useful for people (probably will be), I'm good > with it. > > Ideally, it possibly would check whether the file belongs to the > project-files fileset, but that's going to be slower, and thus probably > not worth the marginal improvement. Then I guess we should install this?