From: Dmitry Gutov <dmitry@gutov.dev>
To: Juri Linkov <juri@linkov.net>
Cc: 63790@debbugs.gnu.org
Subject: bug#63790: 30.0.50; prog-fill-reindent-defun regression
Date: Fri, 9 Jun 2023 04:58:35 +0300 [thread overview]
Message-ID: <83a2971d-b855-e45e-44ae-65b693f0f4bc@gutov.dev> (raw)
In-Reply-To: <86o7lpsxdi.fsf@mail.linkov.net>
On 08/06/2023 19:59, Juri Linkov wrote:
>>> (re-search-forward "\\s-*\\s<" (line-end-position) t)
>>
>> It's looking for a comment that begins after point (possibly preceded by
>> whitespace). There is no comment after point in the presented scenario.
>>
>>> It's nil in the reported case, so 'fill-paragraph' is not called.
>>
>> I guess when there is an active region, we would force the behavior to
>> "refill" the region, no matter whether it is inside a comment, or contains
>> a comment, or outside of any comments and simply contains code?
>
> While 'prog-fill-reindent-defun' doesn't support indentation of an
> arbitrary region of code and indents only the top-level list (defun),
> it looks like the right thing is to fill the region.
Okay?
> I still don't understand why 'M-q' now does the same what 'C-M-q' was
> doing all the time with code indentation?
C-M-q (indent-pp-sexp) reindents the list that follows point. Not the
same thing. And it's only available in Lisp.
> Also why 'prog-fill-reindent-defun'
> can't indent the region of code, but only the region of comments?
Do you want it to?
> Shouldn't 'M-q' only refill comments, and 'C-M-q' only indent code, as before?
Up until now, we thought that making two actions on one key binding
available is a good thing, given that the context usually helps to
disambiguate. This one seems like an exception, but IMHO not a strong
enough one to roll back the change.
next prev parent reply other threads:[~2023-06-09 1:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 16:53 bug#63790: 30.0.50; prog-fill-reindent-defun regression Juri Linkov
2023-06-03 2:40 ` Dmitry Gutov
2023-06-04 17:14 ` Juri Linkov
2023-06-06 1:41 ` Dmitry Gutov
2023-06-06 18:55 ` Juri Linkov
2023-06-08 0:35 ` Dmitry Gutov
2023-06-08 16:59 ` Juri Linkov
2023-06-09 1:58 ` Dmitry Gutov [this message]
2023-06-09 17:37 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a2971d-b855-e45e-44ae-65b693f0f4bc@gutov.dev \
--to=dmitry@gutov.dev \
--cc=63790@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).