From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#63790: 30.0.50; prog-fill-reindent-defun regression Date: Fri, 9 Jun 2023 04:58:35 +0300 Message-ID: <83a2971d-b855-e45e-44ae-65b693f0f4bc@gutov.dev> References: <864jnv6pf8.fsf@mail.linkov.net> <382ab3bd-b9ed-ea18-1ae5-9458ffb1b85c@gutov.dev> <86r0qrtaig.fsf@mail.linkov.net> <86sfb513m2.fsf@mail.linkov.net> <476b767a-2126-50c3-6aa9-6877982ed509@gutov.dev> <86o7lpsxdi.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27993"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Cc: 63790@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 09 03:59:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7RPQ-00071d-AV for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Jun 2023 03:59:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7RP7-0007EV-28; Thu, 08 Jun 2023 21:59:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7RP4-0007Dy-Hv for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 21:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q7RP4-0000SE-9Z for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 21:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q7RP3-0005BG-Kf for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 21:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Jun 2023 01:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63790 X-GNU-PR-Package: emacs Original-Received: via spool by 63790-submit@debbugs.gnu.org id=B63790.168627593019892 (code B ref 63790); Fri, 09 Jun 2023 01:59:01 +0000 Original-Received: (at 63790) by debbugs.gnu.org; 9 Jun 2023 01:58:50 +0000 Original-Received: from localhost ([127.0.0.1]:57939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7ROs-0005Am-1S for submit@debbugs.gnu.org; Thu, 08 Jun 2023 21:58:50 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:53823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7ROn-0005AW-FA for 63790@debbugs.gnu.org; Thu, 08 Jun 2023 21:58:49 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id DCC1D5C016A; Thu, 8 Jun 2023 21:58:39 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 08 Jun 2023 21:58:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1686275919; x=1686362319; bh=3xhMThtVprq+1VFauk31zTAo/lmehQzfJum zHX9my20=; b=yJgV/rj0/9FMKDjHywLshNdZPJE2U9Ehu8HyppFdQJZN10H7eEs RxTp30gniSos43EzM+eUcgZP1TKK2trp928Xzw0kNjHC0pYxZAXNS/DRO9qEmpyH EMQJiSuaRPwhY4TDgUbRfmFDgsD6NIYk05bf0blkR1TwaGOhoeED1/evM0AfOXeE Us3mry2kZxmw2Fd+tbe3D0uXgvIuFwMZKEDkmP0hUYufiaYaYNlN9wnLkigS2dVT QAvv1ZINuZMTr/WYWaWpbZWeNaZb/IjCqj/lMibeL/F6Gr6S5CbcahYo0yoi/Vem izGwEObYUq0vv0A+3P4myE/F4apbGakv0Bw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1686275919; x=1686362319; bh=3xhMThtVprq+1VFauk31zTAo/lmehQzfJum zHX9my20=; b=cmT+yZaWUmLe5+X0qzJdpRckRGGX/s38g5F3mOAmJrsxBHjbIU6 lbyLNxrvZF1Bje2XhLzfmdhVlmOUynndWRc9by6mJGXA3M4gOJCgxJZqGA25fr+e cCTtCkQ0IwZbNVBs90EmB+9PPeEUO0RFzb3DKOEncOquZ5z5Qy22xCwSQvoyiT1Z vOUjpfNiiVkTM9Tit3xRbQe6QQt/lBIWNdWSYuedlg8UZB7HGvLvtT34x5zWLZdU bhKQMAo8D3xXTNvEVii9n7hZ33lDFU3YGBEhxdNguZHTpA4aTMQFYy3mUL6dIEtT EVZR8cekFBCeOJgYGKM2Ej2heBs1Yc6r3Rg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedtjedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 8 Jun 2023 21:58:38 -0400 (EDT) Content-Language: en-US In-Reply-To: <86o7lpsxdi.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263148 Archived-At: On 08/06/2023 19:59, Juri Linkov wrote: >>> (re-search-forward "\\s-*\\s<" (line-end-position) t) >> >> It's looking for a comment that begins after point (possibly preceded by >> whitespace). There is no comment after point in the presented scenario. >> >>> It's nil in the reported case, so 'fill-paragraph' is not called. >> >> I guess when there is an active region, we would force the behavior to >> "refill" the region, no matter whether it is inside a comment, or contains >> a comment, or outside of any comments and simply contains code? > > While 'prog-fill-reindent-defun' doesn't support indentation of an > arbitrary region of code and indents only the top-level list (defun), > it looks like the right thing is to fill the region. Okay? > I still don't understand why 'M-q' now does the same what 'C-M-q' was > doing all the time with code indentation? C-M-q (indent-pp-sexp) reindents the list that follows point. Not the same thing. And it's only available in Lisp. > Also why 'prog-fill-reindent-defun' > can't indent the region of code, but only the region of comments? Do you want it to? > Shouldn't 'M-q' only refill comments, and 'C-M-q' only indent code, as before? Up until now, we thought that making two actions on one key binding available is a good thing, given that the context usually helps to disambiguate. This one seems like an exception, but IMHO not a strong enough one to roll back the change.