From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: 63790@debbugs.gnu.org
Subject: bug#63790: 30.0.50; prog-fill-reindent-defun regression
Date: Tue, 06 Jun 2023 21:55:49 +0300 [thread overview]
Message-ID: <86sfb513m2.fsf@mail.linkov.net> (raw)
In-Reply-To: <cecc72f5-adc1-a4cf-c085-d96bb82e5eb7@gutov.dev> (Dmitry Gutov's message of "Tue, 6 Jun 2023 04:41:55 +0300")
>>>> 3. Type 'M-q' (prog-fill-reindent-defun)
>>>> It indents the list instead of the comment.
>>>> But when point is at the region beginning then 'M-q' correctly indents
>>>> the comments.
>>> This happens because in this scenario point ends up outside of the comment
>>> (at eob). So when the function is called, in looks for a defun.
>>>
>>> Did we at some point add (or decide to add) a condition when, if a region
>>> is active, it should only refill and not reindent?
>> Maybe the logic of region detecting/handling could be copied from
>> 'fill-paragraph' to 'prog-fill-reindent-defun'?
>
> Makes sense. Do you want to suggest a patch?
Sorry, can't do, because I don't understand what this line is intended to do,
and there are no comments with explanations:
(re-search-forward "\\s-*\\s<" (line-end-position) t)
It's nil in the reported case, so 'fill-paragraph' is not called.
next prev parent reply other threads:[~2023-06-06 18:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 16:53 bug#63790: 30.0.50; prog-fill-reindent-defun regression Juri Linkov
2023-06-03 2:40 ` Dmitry Gutov
2023-06-04 17:14 ` Juri Linkov
2023-06-06 1:41 ` Dmitry Gutov
2023-06-06 18:55 ` Juri Linkov [this message]
2023-06-08 0:35 ` Dmitry Gutov
2023-06-08 16:59 ` Juri Linkov
2023-06-09 1:58 ` Dmitry Gutov
2023-06-09 17:37 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86sfb513m2.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=63790@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).