unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no,
	jostein@secure.kjonigsen.net, dev@rjt.dev
Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list
Date: Fri, 03 Feb 2023 08:45:15 +0200	[thread overview]
Message-ID: <838rhfw8lg.fsf@gnu.org> (raw)
In-Reply-To: <250a9090-8415-9fda-1622-cc9073328fb9@yandex.ru> (message from Dmitry Gutov on Fri, 3 Feb 2023 04:51:04 +0200)

> Cc: 61205@debbugs.gnu.org, Theodor Thornhill <theo@thornhill.no>,
>  Jostein Kjønigsen <jostein@secure.kjonigsen.net>,
>  randy taylor <dev@rjt.dev>
> Date: Fri, 3 Feb 2023 04:51:04 +0200
> From: Dmitry Gutov <dgutov@yandex.ru>
> 
> >> On a related note: 'property' is in level 3 in c-ts-mode.
> >>
> >> Should it to go level 4?
> > 
> > I believe property is level 3. Quoting the (emacs) manual:
> > 
> > Level 1
> >       This level usually fontifies only comments and function names in
> >       function definitions.
> > Level 2
> >       This level adds fontification of keywords, strings, and data types.
> > Level 3
> >       This is the default level; it adds fontification of assignments,
> >       numbers, properties, etc.
> > Level 4
> >       This level adds everything else that can be fontified: operators,
> >       delimiters, brackets, other punctuation, function names in function
> >       calls, variables, etc.
> 
> The manual could be updated.
> 
> Here's where we seem to have agreed that is should be level 4: 
> https://lists.gnu.org/archive/html/emacs-devel/2022-12/msg01221.html

Whatever you decide, please keep the doc string of
treesit-font-lock-level and the manual in sync.  I already needed to
fix those more than once because the code "disagreed" with the
documentation.  The pretest is too close for us to be able to sustain
such inaccuracies and resolve them in time.

So please present the patches to this effect for review and comments
before installing them.  TIA.





  reply	other threads:[~2023-02-03  6:45 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-01  2:08 bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Dmitry Gutov
2023-02-01  5:18 ` Yuan Fu
2023-02-02  2:34   ` Dmitry Gutov
2023-02-02  3:18     ` Randy Taylor
2023-02-02 11:03       ` Dmitry Gutov
2023-02-02 20:25   ` Dmitry Gutov
2023-02-03  2:38     ` Yuan Fu
2023-02-03  2:51       ` Dmitry Gutov
2023-02-03  6:45         ` Eli Zaretskii [this message]
2023-02-03  6:46     ` Eli Zaretskii
2023-02-03 11:42       ` Dmitry Gutov
2023-02-03 12:19         ` Eli Zaretskii
2023-02-03 15:15           ` Dmitry Gutov
2023-02-03 15:54             ` Eli Zaretskii
2023-02-03 17:10               ` Dmitry Gutov
2023-02-04  3:36                 ` Dmitry Gutov
2023-02-04  6:53                   ` Eli Zaretskii
2023-02-04 23:44                     ` Dmitry Gutov
2023-02-05  6:05                       ` Eli Zaretskii
2023-02-05 13:52                         ` Dmitry Gutov
2023-02-02  2:34 ` Randy Taylor
2023-02-02  2:44   ` Dmitry Gutov
2023-02-02  3:29     ` Randy Taylor
2023-02-02 11:11       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838rhfw8lg.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=61205@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=dev@rjt.dev \
    --cc=dgutov@yandex.ru \
    --cc=jostein@secure.kjonigsen.net \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).