From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, dev@rjt.dev
Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list
Date: Fri, 03 Feb 2023 14:19:40 +0200 [thread overview]
Message-ID: <83k00zuejn.fsf@gnu.org> (raw)
In-Reply-To: <1b8044bd-6855-fdc7-697d-70322a8349c0@yandex.ru> (message from Dmitry Gutov on Fri, 3 Feb 2023 13:42:51 +0200)
> Date: Fri, 3 Feb 2023 13:42:51 +0200
> Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, dev@rjt.dev
> From: Dmitry Gutov <dgutov@yandex.ru>
>
> On 03/02/2023 08:46, Eli Zaretskii wrote:
> >> Cc:61205@debbugs.gnu.org, Theodor Thornhill<theo@thornhill.no>,
> >> randy taylor<dev@rjt.dev>
> >> Date: Thu, 2 Feb 2023 22:25:47 +0200
> >> From: Dmitry Gutov<dgutov@yandex.ru>
> >>
> >> On a related note: 'property' is in level 3 in c-ts-mode.
> >>
> >> Should it to go level 4?
> >>
> >> Also in typescript-ts-mode.
> > What is 'property' in those modes? In c-ts-mode, is 'property' the
> > name of a struct or enum member, as in foo.bar? Or is it something
> > else?
>
> It's the 'bar' in 'foo.bar', yes. Specifically in the cases where it's
> being looked up, rather than defined (in a type definition). Examples:
>
> it2.lnum_pixel_width = it.lnum_pixel_width;
>
> || (it.bidi_p && it.bidi_it.scan_dir == -1
>
> 'lnum_pixel_width', 'bidi_p', 'bidi_it' and 'scan_dir' are highlighted
> with font-lock-property-face. You can see it for yourself by trying
> c-ts-mode in any of our files.
Then as far as I'm concerned, this can go to level 4, but it must be
done consistently across all the *-ts modes. So if some mode wants
'property' to be highlighted, and wants it badly, we should IMO keep
it in C as well.
In any case, please make this consistent across all the relevant
modes, and don't forget adjusting the documentation of
treesit-font-lock-level accordingly as needed.
next prev parent reply other threads:[~2023-02-03 12:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 2:08 bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Dmitry Gutov
2023-02-01 5:18 ` Yuan Fu
2023-02-02 2:34 ` Dmitry Gutov
2023-02-02 3:18 ` Randy Taylor
2023-02-02 11:03 ` Dmitry Gutov
2023-02-02 20:25 ` Dmitry Gutov
2023-02-03 2:38 ` Yuan Fu
2023-02-03 2:51 ` Dmitry Gutov
2023-02-03 6:45 ` Eli Zaretskii
2023-02-03 6:46 ` Eli Zaretskii
2023-02-03 11:42 ` Dmitry Gutov
2023-02-03 12:19 ` Eli Zaretskii [this message]
2023-02-03 15:15 ` Dmitry Gutov
2023-02-03 15:54 ` Eli Zaretskii
2023-02-03 17:10 ` Dmitry Gutov
2023-02-04 3:36 ` Dmitry Gutov
2023-02-04 6:53 ` Eli Zaretskii
2023-02-04 23:44 ` Dmitry Gutov
2023-02-05 6:05 ` Eli Zaretskii
2023-02-05 13:52 ` Dmitry Gutov
2023-02-02 2:34 ` Randy Taylor
2023-02-02 2:44 ` Dmitry Gutov
2023-02-02 3:29 ` Randy Taylor
2023-02-02 11:11 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k00zuejn.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=61205@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dev@rjt.dev \
--cc=dgutov@yandex.ru \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).