From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Date: Fri, 03 Feb 2023 08:45:15 +0200 Message-ID: <838rhfw8lg.fsf@gnu.org> References: <645D27C7-0376-45F9-A5C9-CD84F9467ED4@gmail.com> <250a9090-8415-9fda-1622-cc9073328fb9@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1812"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, jostein@secure.kjonigsen.net, dev@rjt.dev To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 03 07:46:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNpq8-0000BB-0N for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Feb 2023 07:46:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNppq-0003eb-KC; Fri, 03 Feb 2023 01:46:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNppj-0003eG-75 for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2023 01:46:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pNppi-0000oR-V4 for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2023 01:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pNppi-0004lq-HV for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2023 01:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Feb 2023 06:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs Original-Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.167540672518284 (code B ref 61205); Fri, 03 Feb 2023 06:46:02 +0000 Original-Received: (at 61205) by debbugs.gnu.org; 3 Feb 2023 06:45:25 +0000 Original-Received: from localhost ([127.0.0.1]:36361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNpp7-0004kp-3g for submit@debbugs.gnu.org; Fri, 03 Feb 2023 01:45:25 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNpp4-0004ka-N2 for 61205@debbugs.gnu.org; Fri, 03 Feb 2023 01:45:23 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNpoz-0000YC-4T; Fri, 03 Feb 2023 01:45:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=fpRplM6LSHJq3cm6IwGgNhR5WO+qFpmj7ilFFQ2kD2g=; b=Elyx1L5pMP43M9oUOjZ+ V93kqNVnpsH3Qgg+7ApyL47FieUF49CNqDEMHh4nKaJC+exY8j99mlYDvAhTm+UuoVGoZAbUzW4RV Mq2NrfUCUe/GzwcxBdUInZmZKGhHBJ9REahnEB6a67qZ6xpPVO5E8ORNfkVs6rg3FCWNYsCRPlO/o uixZ2oXKTwtFFGuTgtio1T/yZkH2HAzKC05fV6N3Cql2wMTGAjsUExYBfKhnhsYcUT3ilB1sMVALv 28dbqavaC2XqZA5bj/pkzeT1bLEGs34us0bcMrW3JeKHFCgCvt5Cwa+Z3blr17WKkkSR9DBZC6MC+ wDYekOqzKh7dPg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNpov-000660-6y; Fri, 03 Feb 2023 01:45:16 -0500 In-Reply-To: <250a9090-8415-9fda-1622-cc9073328fb9@yandex.ru> (message from Dmitry Gutov on Fri, 3 Feb 2023 04:51:04 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254710 Archived-At: > Cc: 61205@debbugs.gnu.org, Theodor Thornhill , > Jostein Kjønigsen , > randy taylor > Date: Fri, 3 Feb 2023 04:51:04 +0200 > From: Dmitry Gutov > > >> On a related note: 'property' is in level 3 in c-ts-mode. > >> > >> Should it to go level 4? > > > > I believe property is level 3. Quoting the (emacs) manual: > > > > Level 1 > > This level usually fontifies only comments and function names in > > function definitions. > > Level 2 > > This level adds fontification of keywords, strings, and data types. > > Level 3 > > This is the default level; it adds fontification of assignments, > > numbers, properties, etc. > > Level 4 > > This level adds everything else that can be fontified: operators, > > delimiters, brackets, other punctuation, function names in function > > calls, variables, etc. > > The manual could be updated. > > Here's where we seem to have agreed that is should be level 4: > https://lists.gnu.org/archive/html/emacs-devel/2022-12/msg01221.html Whatever you decide, please keep the doc string of treesit-font-lock-level and the manual in sync. I already needed to fix those more than once because the code "disagreed" with the documentation. The pretest is too close for us to be able to sustain such inaccuracies and resolve them in time. So please present the patches to this effect for review and comments before installing them. TIA.