From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer Date: Sat, 30 Dec 2023 08:30:29 +0200 Message-ID: <838r5c5hiy.fsf@gnu.org> References: <87o7f3e4cb.fsf@melete.silentflame.com> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> <87le9pxivy.fsf@zephyr.silentflame.com> <87frzk294o.fsf@zephyr.silentflame.com> <87bka828jm.fsf@zephyr.silentflame.com> <83bka86c8r.fsf@gnu.org> <877ckw21vp.fsf@zephyr.silentflame.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="961"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67661@debbugs.gnu.org, me@eshelyaron.com, juri@linkov.net To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 30 07:31:33 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rJSsf-000AbJ-4o for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Dec 2023 07:31:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rJSsC-0005NQ-Lb; Sat, 30 Dec 2023 01:31:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJSsA-0005ML-9Q for bug-gnu-emacs@gnu.org; Sat, 30 Dec 2023 01:31:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rJSsA-00048x-1W for bug-gnu-emacs@gnu.org; Sat, 30 Dec 2023 01:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rJSsA-00079J-66 for bug-gnu-emacs@gnu.org; Sat, 30 Dec 2023 01:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Dec 2023 06:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67661 X-GNU-PR-Package: emacs Original-Received: via spool by 67661-submit@debbugs.gnu.org id=B67661.170391784926257 (code B ref 67661); Sat, 30 Dec 2023 06:31:02 +0000 Original-Received: (at 67661) by debbugs.gnu.org; 30 Dec 2023 06:30:49 +0000 Original-Received: from localhost ([127.0.0.1]:42879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJSrx-0006oV-2S for submit@debbugs.gnu.org; Sat, 30 Dec 2023 01:30:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJSru-0006bQ-8Z for 67661@debbugs.gnu.org; Sat, 30 Dec 2023 01:30:47 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJSrn-00045B-1I; Sat, 30 Dec 2023 01:30:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OxroWjuaLfWKZ2njERNyTy2t2vTc42r24BKvccQVosY=; b=e+tki3xdrR/e 5eZ4FBgDKdm+Myc6GQ85seeosrJg1oM5M+pe5Z5OuuXG8hIQnZcYrC6JxhJneTUbvhTF8Xg7ukJqt Pao3SIya8JnYN0y2iCFjm2jA7xz765N+DpuDi0zkOtwyvS0fzFy9bi4dxuxdDJly5lSFcxD6vTN6p 214qYNmM2YCfWUncf6pdxgir7dL0RUTfZoWgYdYnJFY2vBK6+YQHQBvXZSQNCiZEVheEzxthbL1EK 7BEMUWnlRThmxG3jOW/DDL6INy4QIdGvja1sF5363wbFSLX87VR2h9srH1Rux5oNXOTVpc12QyD3Z OhPrv4PUyrxu29Dg08JgbA==; In-Reply-To: <877ckw21vp.fsf@zephyr.silentflame.com> (message from Sean Whitton on Fri, 29 Dec 2023 20:24:26 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277056 Archived-At: > From: Sean Whitton > Cc: me@eshelyaron.com, 67661@debbugs.gnu.org > Date: Fri, 29 Dec 2023 20:24:26 +0000 > > On Fri 29 Dec 2023 at 09:27pm +02, Eli Zaretskii wrote: > > > To which entry in Emacs 29's NEWS would this be related? > > I'm talking about how Juri fixed icomplete-in-buffer for Emacs 29, and > how it's now working differently. Juri's fix wasn't noted in NEWS.29, > so there isn't a relevant entry. I thought you were suggesting to add something to NEWS in Emacs 29. If there's no suitable entry there, then I wonder what did you have in mind for Emacs 29 in this area. > Thus, I propose adding a NEWS.30 entry like this: > > There have been some changes which normalise some behaviour of > in-buffer completion that affect users of icomplete-in-buffer. > > Firstly, completion-auto-help now governs icomplete-in-buffer, > whereas previously it affected only minibuffer completion. You may > wish to review any existing customisation for completion-auto-help > if in-buffer completion behaves in a way that surprises you. > > Secondly, the *Completions* buffer now always pops up at the same > time that Icomplete displays its in-buffer completion. If you would > prefer to see only Icomplete's display, which is what you might be > used to, you could use > > (advice-add 'completion-at-point :after #'minibuffer-hide-completions) AFAIU, this should also mention changes in Emacs 29 wrt previous versions. Also, the entry should in terms of user-facing behavior, not in terms of how code works. It should also be more concrete; phrases like "you may wish to review existing customizations" are too vague to be useful. The last paragraph seems to indicate we lack some user option or a variable to get back the old behavior, since using advice-add is less friendly than flipping a variable. (IMO, we are making too many backward-incompatible changes in this area lately. But that's me.)