From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27 Date: Sat, 07 Mar 2020 09:43:39 +0200 Message-ID: <837dzwboes.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="14945"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39960@debbugs.gnu.org To: Philipp , Michael Mauger Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 07 08:44:20 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jAU8C-0003o3-3d for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Mar 2020 08:44:20 +0100 Original-Received: from localhost ([::1]:46032 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAU8A-0003yZ-MT for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Mar 2020 02:44:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52337) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAU7w-0003yM-Jl for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2020 02:44:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jAU7v-0000Eu-6h for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2020 02:44:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40213) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jAU7u-0000DB-2V for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2020 02:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jAU7t-0000zz-Vz for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2020 02:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Mar 2020 07:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39960 X-GNU-PR-Package: emacs Original-Received: via spool by 39960-submit@debbugs.gnu.org id=B39960.15835670283811 (code B ref 39960); Sat, 07 Mar 2020 07:44:01 +0000 Original-Received: (at 39960) by debbugs.gnu.org; 7 Mar 2020 07:43:48 +0000 Original-Received: from localhost ([127.0.0.1]:46186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAU7g-0000zP-IG for submit@debbugs.gnu.org; Sat, 07 Mar 2020 02:43:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAU7e-0000zC-Rl for 39960@debbugs.gnu.org; Sat, 07 Mar 2020 02:43:47 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35871) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jAU7Z-0007LO-HQ; Sat, 07 Mar 2020 02:43:41 -0500 Original-Received: from [176.228.60.248] (port=2521 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jAU7Z-0007ts-0B; Sat, 07 Mar 2020 02:43:41 -0500 In-Reply-To: (message from Philipp on Fri, 06 Mar 2020 23:39:16 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176989 Archived-At: > From: Philipp > Date: Fri, 06 Mar 2020 23:39:16 +0100 > > > In Emacs 26, sql-add-product has the signature > > (sql-add-product PRODUCT DISPLAY &rest PLIST) > > However, in the Emacs 27 pretest the signature is now > > (sql-add-product PRODUCT DISPLAY &optional PLIST) > > Note the change from &rest to &optional. This is a breaking change that > breaks all users of sql-add-product. I've found quite a few uses of the > old signature in the wild, > e.g. https://github.com/kat-co/sql-prestodb/blob/f4a74d88dcb166445bb41efb865147c0faf1de3a/src/sql-presto.el#L59 > or > https://github.com/r0man/vertica-el/blob/3c9647b425c5c13c30bf0cba483646af18196588/vertica.el#L68 > or > https://github.com/jterk/sql-impala/blob/466e7c0c789ec3e5e8a276c8f6754f91bb584c3e/sql-impala.el#L71. > This change was introduced in commit > c124d5323c05a4010db9b2d330575d029936ade1. I don't think we should > introduce such a breaking change to a widely-used public function; at > the very least, Emacs 27 should accept both signatures. Thanks for reporting this. Michael, could you please look into this ASAP? TIA. Btw, this change of a public API is not in NEWS, AFAICT; if we decide eventually on keeping the change, we should announce it in NEWS.