From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55696: 28.1; eshell fails to respect text-scale-increase Date: Thu, 09 Jun 2022 19:48:28 +0300 Message-ID: <837d5p3hr7.fsf@gnu.org> References: <37af046b-4257-6370-c765-9290eae73fd4@gmail.com> <831qw6dzra.fsf@gnu.org> <0278e759-237b-a32b-4b1f-fbdacf39c8ef@gmail.com> <83pmjpar0x.fsf@gnu.org> <9e8a8b42-2f42-3027-2ec0-97744bb91911@gmail.com> <83sfoja2xp.fsf@gnu.org> <34062848-8fe4-351c-df63-5cc341fefa57@gmail.com> <83sfoj7x6f.fsf@gnu.org> <83ee027yjc.fsf@gnu.org> <2b86123e-76c1-ec0c-c767-7d821473e5e1@gmx.at> <86a0c66e-86f9-6bd6-2010-eb1cf2d9f1e6@gmail.com> <83a6am47v6.fsf@gnu.org> <4abda9a0-7c34-cdad-fc9e-a6dc25e7c74b@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40252"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55696@debbugs.gnu.org, jeff.kowalski@gmail.com To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 09 20:36:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzN0z-000AHZ-7v for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Jun 2022 20:36:17 +0200 Original-Received: from localhost ([::1]:54264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzN0x-0001ZF-Lw for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Jun 2022 14:36:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzLLC-0001u9-HT for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2022 12:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53684) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nzLLC-0006bZ-8w for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2022 12:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nzLLC-0005TZ-5R for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2022 12:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jun 2022 16:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55696 X-GNU-PR-Package: emacs Original-Received: via spool by 55696-submit@debbugs.gnu.org id=B55696.165479331920994 (code B ref 55696); Thu, 09 Jun 2022 16:49:02 +0000 Original-Received: (at 55696) by debbugs.gnu.org; 9 Jun 2022 16:48:39 +0000 Original-Received: from localhost ([127.0.0.1]:47578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzLKp-0005SX-7c for submit@debbugs.gnu.org; Thu, 09 Jun 2022 12:48:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzLKo-0005SM-1b for 55696@debbugs.gnu.org; Thu, 09 Jun 2022 12:48:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:32914) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzLKi-0006a9-M1; Thu, 09 Jun 2022 12:48:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yyYF0iBWakmZzOMH/3RLZjcFH0NikhmnhTNDlC801gw=; b=QNq1u/0h4RGw evZUhxq2S0S71Ax4L4zv4pj/CDfUPHt9L2jajU9taSGZxlf1S4ytTy+wrUGs+kQy/+AR7uX3pJ+cu AsfpbTl0Unfy3JiMkgY2bAZCPNGTBpeAX2LxU7vyMFMHPZrPy48/mm3EvbtFwx6b++CmQjNNiltD1 4RcnR3mVjSKntpz4znGnNkS9PdymvMLQgcEQWpxmy8T9ZaB3umPKGy5ftIKLvVmcpdrCq53JEd/Lt Qfsy5CHjztGx0qndcaY7zkEv0hPODwwodm/u4ClkVW2rHbywTiNPKZTsA/F7mOmnj4H6xPVcLUXev uVb6YwoQKNm1icCnpjY80Q==; Original-Received: from [87.69.77.57] (port=3932 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzLKh-0004s5-NJ; Thu, 09 Jun 2022 12:48:32 -0400 In-Reply-To: <4abda9a0-7c34-cdad-fc9e-a6dc25e7c74b@gmail.com> (message from Jim Porter on Thu, 9 Jun 2022 08:55:36 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234141 Archived-At: > From: Jim Porter > Date: Thu, 9 Jun 2022 08:55:36 -0700 > > Do the tests work if you replace "list" in those two functions with > "listify"? (`eshell/listify' is a built-in Eshell alias function, which > is the highest priority for Eshell commands, so it should always work.) If I make this replacement in 4 tests that use "list", then it doesn't hang, but 2 tests fail: Test esh-var-test/interp-lisp-indices backtrace: (listify 1 2) eval((listify 1 2)) eshell-exec-lisp(eshell-print eshell-error (listify 1 2) nil t) eshell-lisp-command((listify 1 2)) eval((eshell-lisp-command '(listify 1 2))) eshell-do-eval((eshell-lisp-command '(listify 1 2)) t) eshell-do-eval((progn (eshell-lisp-command '(listify 1 2)) (symbol-v #f(compiled-function () #)() funcall(#f(compiled-function () #)) (let ((eshell-current-handles '[nil (eshell-temp . 1) (eshell-temp . eval((let ((eshell-current-handles '[nil (eshell-temp . 1) (eshell-t eshell-do-eval((let ((eshell-current-handles '[nil (eshell-temp . 1) #f(compiled-function () #)() funcall(#f(compiled-function () #)) (let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil)) (funcall '#f eval((let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil)) (funcal eshell-do-eval((let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil eshell-do-eval((eshell-apply-indices (let ((value 'eshell-temp) (esh #f(compiled-function () #)() funcall(#f(compiled-function () #)) (let ((indices '((#("1" 0 1 (number t)))))) (funcall '#f(compiled-fu eval((let ((indices '((#("1" 0 1 ...))))) (funcall '#f(compiled-func eshell-do-eval((let ((indices '((#("1" 0 1 ...))))) (eshell-apply-in eshell-do-eval((eshell-escape-arg (let ((indices '((...)))) (eshell- eshell-do-eval((list (eshell-escape-arg (let ((indices '(...))) (esh eshell-do-eval((eshell-named-command '"+" (list (eshell-escape-arg ( eshell-do-eval((prog1 (eshell-named-command '"+" (list (eshell-escap (condition-case err (eshell-do-eval '(prog1 (eshell-named-command '" eval((condition-case err (eshell-do-eval '(prog1 (eshell-named-comma eshell-do-eval((condition-case err (eshell-do-eval '(prog1 (eshell-n #f(compiled-function () #)() funcall(#f(compiled-function () #)) (let ((eshell-this-command-hook '(ignore))) (funcall '#f(compiled-fu eval((let ((eshell-this-command-hook '(ignore))) (funcall '#f(compil eshell-do-eval((let ((eshell-this-command-hook '(ignore))) (conditio eshell-do-eval((progn (let ((eshell-this-command-hook '(ignore))) (c #f(compiled-function () #)() funcall(#f(compiled-function () #)) (let ((eshell-current-handles '[nil (eshell-temp . 1) (eshell-temp . eval((let ((eshell-current-handles '[nil (eshell-temp . 1) (eshell-t eshell-do-eval((let ((eshell-current-handles '[nil (eshell-temp . 1) #f(compiled-function () #)() funcall(#f(compiled-function () #)) (let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil)) (funcall '#f eval((let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil)) (funcal eshell-do-eval((let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil #f(compiled-function () #)() funcall(#f(compiled-function () #)) (let ((eshell-current-handles '[nil (t . 1) (t . 1)]) (eshell-curren eval((let ((eshell-current-handles '[nil (t . 1) (t . 1)]) (eshell-c eshell-do-eval((let ((eshell-current-handles '[nil (t . 1) (t . 1)]) eshell-command-result("+ $(listify 1 2)[1] 3") (let ((eshell-history-file-name nil)) (eshell-command-result command (progn (let ((eshell-history-file-name nil)) (eshell-command-result (unwind-protect (progn (let ((eshell-history-file-name nil)) (eshell (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct eshell-test-command-result("+ $(listify 1 2)[1] 3") (list (eshell-test-command-result "+ $(listify 1 2)[1] 3") 5) (let ((signal-hook-function #'ert--should-signal-hook)) (list (eshel (condition-case err (let ((signal-hook-function #'ert--should-signal (let* ((fn-140 #'equal) (args-141 (condition-case err (let ((signal- (closure (t) nil (let* ((fn-140 #'equal) (args-141 (condition-case e ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name esh-var-test/interp-lisp-indices :doc ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n command-line-1(("-L" ";." "-l" "ert" "-l" "lisp/eshell/esh-var-tests command-line() normal-top-level() Test esh-var-test/interp-lisp-indices condition: (void-function listify) FAILED 20/60 esh-var-test/interp-lisp-indices (0.015625 sec) at lisp/eshell/esh-var-tests.el:140 [...] Test esh-var-test/quoted-interp-lisp-indices backtrace: (listify 1 2) eval((listify 1 2)) eshell-exec-lisp(eshell-print eshell-error (listify 1 2) nil t) eshell-lisp-command((listify 1 2)) eval((eshell-lisp-command '(listify 1 2))) eshell-do-eval((eshell-lisp-command '(listify 1 2)) t) eshell-do-eval((progn (eshell-lisp-command '(listify 1 2)) (symbol-v #f(compiled-function () #)() funcall(#f(compiled-function () #)) (let ((eshell-current-handles '[nil (eshell-temp . 1) (eshell-temp . eval((let ((eshell-current-handles '[nil (eshell-temp . 1) (eshell-t eshell-do-eval((let ((eshell-current-handles '[nil (eshell-temp . 1) #f(compiled-function () #)() funcall(#f(compiled-function () #)) (let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil)) (funcall '#f eval((let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil)) (funcal eshell-do-eval((let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil eshell-do-eval((eshell-apply-indices (let ((value 'eshell-temp) (esh #f(compiled-function () #)() funcall(#f(compiled-function () #)) (let ((indices '((#("1" 0 1 (number t)))))) (funcall '#f(compiled-fu eval((let ((indices '((#("1" 0 1 ...))))) (funcall '#f(compiled-func eshell-do-eval((let ((indices '((#("1" 0 1 ...))))) (eshell-apply-in eshell-do-eval((eshell-stringify (let ((indices '((...)))) (eshell-a eshell-do-eval((eshell-escape-arg (eshell-stringify (let ((indices ' eshell-do-eval((eshell-escape-arg (eshell-escape-arg (eshell-stringi eshell-do-eval((list (eshell-escape-arg (eshell-escape-arg (eshell-s eshell-do-eval((eshell-named-command '"concat" (list (eshell-escape- eshell-do-eval((prog1 (eshell-named-command '"concat" (list (eshell- (condition-case err (eshell-do-eval '(prog1 (eshell-named-command '" eval((condition-case err (eshell-do-eval '(prog1 (eshell-named-comma eshell-do-eval((condition-case err (eshell-do-eval '(prog1 (eshell-n #f(compiled-function () #)() funcall(#f(compiled-function () #)) (let ((eshell-this-command-hook '(ignore))) (funcall '#f(compiled-fu eval((let ((eshell-this-command-hook '(ignore))) (funcall '#f(compil eshell-do-eval((let ((eshell-this-command-hook '(ignore))) (conditio eshell-do-eval((progn (let ((eshell-this-command-hook '(ignore))) (c #f(compiled-function () #)() funcall(#f(compiled-function () #)) (let ((eshell-current-handles '[nil (eshell-temp . 1) (eshell-temp . eval((let ((eshell-current-handles '[nil (eshell-temp . 1) (eshell-t eshell-do-eval((let ((eshell-current-handles '[nil (eshell-temp . 1) #f(compiled-function () #)() funcall(#f(compiled-function () #)) (let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil)) (funcall '#f eval((let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil)) (funcal eshell-do-eval((let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil #f(compiled-function () #)() funcall(#f(compiled-function () #)) (let ((eshell-current-handles '[nil (t . 1) (t . 1)]) (eshell-curren eval((let ((eshell-current-handles '[nil (t . 1) (t . 1)]) (eshell-c eshell-do-eval((let ((eshell-current-handles '[nil (t . 1) (t . 1)]) eshell-command-result("concat \"$(listify 1 2)[1]\" cool") (let ((eshell-history-file-name nil)) (eshell-command-result command (progn (let ((eshell-history-file-name nil)) (eshell-command-result (unwind-protect (progn (let ((eshell-history-file-name nil)) (eshell (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct eshell-test-command-result("concat \"$(listify 1 2)[1]\" cool") (list (eshell-test-command-result "concat \"$(listify 1 2)[1]\" cool (let ((signal-hook-function #'ert--should-signal-hook)) (list (eshel (condition-case err (let ((signal-hook-function #'ert--should-signal (let* ((fn-330 #'equal) (args-331 (condition-case err (let ((signal- (closure (t) nil (let* ((fn-330 #'equal) (args-331 (condition-case e ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name esh-var-test/quoted-interp-lisp-indic ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n command-line-1(("-L" ";." "-l" "ert" "-l" "lisp/eshell/esh-var-tests command-line() normal-top-level() Test esh-var-test/quoted-interp-lisp-indices condition: (void-function listify) FAILED 49/60 esh-var-test/quoted-interp-lisp-indices (0.015625 sec) at lisp/eshell/esh-var-tests.el:318