From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 60015@debbugs.gnu.org, juri@linkov.net
Subject: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer
Date: Thu, 15 Dec 2022 15:36:24 +0200 [thread overview]
Message-ID: <837cyslrfr.fsf@gnu.org> (raw)
In-Reply-To: <32f8777a-2bc3-961c-e773-46451f2b9282@gmx.at> (message from martin rudalics on Thu, 15 Dec 2022 11:18:15 +0100)
> Date: Thu, 15 Dec 2022 11:18:15 +0100
> Cc: 60015@debbugs.gnu.org
> From: martin rudalics <rudalics@gmx.at>
>
> > Here is a better test case. Please evaluate:
> >
> > (progn
> > (keymap-global-set "C-c C-c" (lambda () (interactive) (message "abc\ndef")))
> > nil)
> >
> > Then the bug can be reproduced with just these keys:
> >
> > M-x
> > C-x o
> > C-c C-c
> >
> > Only the top line is displayed in the minibuffer.
>
> This is caused by resize_echo_area_exactly in xdisp.c. If you replace
>
> Lisp_Object resize_exactly = (minibuf_level == 0 ? Qt : Qnil);
>
> with
>
> Lisp_Object resize_exactly = Qt;
>
> the echo area gets resized.
Are you sure this is the reason and the possible fix? The commentary
to resize_echo_area_exactly says:
/* Resize the echo area window to exactly the size needed for the
currently displayed message, if there is one. If a mini-buffer
is active, don't shrink it. */
which makes a lot of sense. And resize_mini_window, which does the
job and accepts the argument you suggest to make Qt always, has this
single place where it looks at that argument (called EXACT_P):
if (EQ (Vresize_mini_windows, Qgrow_only))
{
/* Let it grow only, until we display an empty message, in which
case the window shrinks again. */
if (height > old_height)
grow_mini_window (w, height - old_height);
else if (height < old_height && (exact_p || BEGV == ZV))
shrink_mini_window (w);
}
So this argument cannot have any effect on enlarging the mini-window,
only on shrinking it. Or am I missing something?
next prev parent reply other threads:[~2022-12-15 13:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 18:03 bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer Juri Linkov
2022-12-12 18:19 ` Eli Zaretskii
2022-12-12 18:37 ` Juri Linkov
2022-12-12 19:20 ` Eli Zaretskii
2022-12-13 17:20 ` Juri Linkov
2022-12-13 17:44 ` Eli Zaretskii
2022-12-13 17:56 ` Juri Linkov
2022-12-15 7:44 ` Juri Linkov
2022-12-15 10:18 ` martin rudalics
2022-12-15 13:36 ` Eli Zaretskii [this message]
2022-12-15 14:30 ` Eli Zaretskii
2022-12-15 15:07 ` martin rudalics
2022-12-15 15:12 ` martin rudalics
2022-12-15 15:30 ` Eli Zaretskii
2022-12-15 17:35 ` Juri Linkov
2022-12-17 17:39 ` Juri Linkov
2022-12-17 18:45 ` Eli Zaretskii
2022-12-15 16:44 ` Gregory Heytings
2022-12-15 17:03 ` Eli Zaretskii
2022-12-15 17:37 ` Juri Linkov
2022-12-15 21:52 ` Gregory Heytings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837cyslrfr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=60015@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).