unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: rudalics@gmx.at, 60015-done@debbugs.gnu.org
Subject: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer
Date: Sat, 17 Dec 2022 20:45:34 +0200	[thread overview]
Message-ID: <837cyphnsh.fsf@gnu.org> (raw)
In-Reply-To: <868rj6ylne.fsf@mail.linkov.net> (message from Juri Linkov on Sat, 17 Dec 2022 19:39:49 +0200)

> From: Juri Linkov <juri@linkov.net>
> Cc: martin rudalics <rudalics@gmx.at>,  60015@debbugs.gnu.org
> Date: Sat, 17 Dec 2022 19:39:49 +0200
> 
> > Juri, does the patch below give good results?  It's a bit of overkill,
> > since the mini-window usually doesn't need any resizing, but maybe
> > that is not too bad.
> >
> > If it seems to solve the problem, would you please run with this for a
> > couple of weeks, and report back if you see any problems?  If there
> > are no problems, I'll then install this on the emacs-29 branch.
> >
> > diff --git a/src/xdisp.c b/src/xdisp.c
> > index d14cd46..45da496 100644
> > --- a/src/xdisp.c
> > +++ b/src/xdisp.c
> > @@ -19429,6 +19429,13 @@ redisplay_window (Lisp_Object window, bool just_this_one_p)
> >  	    blank_row (w, row, y);
> >  	  goto finish_scroll_bars;
> >  	}
> > +      else if (minibuf_level >= 1)
> > +	{
> > +	  /* We could have a message produced by set-minibuffer-message
> > +	     displayed in the mini-window as an overlay, so resize the
> > +	     mini-window if needed.  */
> > +	  resize_mini_window (w, false);
> > +	}
> 
> I tested it for a while and see no problems with it.

Thanks, installed on the emacs-29 branch, and closing this bug.





  reply	other threads:[~2022-12-17 18:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-12 18:03 bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer Juri Linkov
2022-12-12 18:19 ` Eli Zaretskii
2022-12-12 18:37   ` Juri Linkov
2022-12-12 19:20     ` Eli Zaretskii
2022-12-13 17:20       ` Juri Linkov
2022-12-13 17:44         ` Eli Zaretskii
2022-12-13 17:56           ` Juri Linkov
2022-12-15  7:44             ` Juri Linkov
2022-12-15 10:18               ` martin rudalics
2022-12-15 13:36                 ` Eli Zaretskii
2022-12-15 14:30                   ` Eli Zaretskii
2022-12-15 15:07                     ` martin rudalics
2022-12-15 15:12                       ` martin rudalics
2022-12-15 15:30                         ` Eli Zaretskii
2022-12-15 17:35                           ` Juri Linkov
2022-12-17 17:39                           ` Juri Linkov
2022-12-17 18:45                             ` Eli Zaretskii [this message]
2022-12-15 16:44               ` Gregory Heytings
2022-12-15 17:03                 ` Eli Zaretskii
2022-12-15 17:37                   ` Juri Linkov
2022-12-15 21:52                     ` Gregory Heytings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837cyphnsh.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=60015-done@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).