From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer Date: Thu, 15 Dec 2022 15:36:24 +0200 Message-ID: <837cyslrfr.fsf@gnu.org> References: <86y1rco5xe.fsf@mail.linkov.net> <83cz8oqybf.fsf@gnu.org> <86zgbsmpta.fsf@mail.linkov.net> <83a63sqvhq.fsf@gnu.org> <865yefw7o5.fsf@mail.linkov.net> <83r0x3nqq6.fsf@gnu.org> <86h6xzrxug.fsf@mail.linkov.net> <86mt7pgkzh.fsf@mail.linkov.net> <32f8777a-2bc3-961c-e773-46451f2b9282@gmx.at> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32572"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60015@debbugs.gnu.org, juri@linkov.net To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 15 14:38:47 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5oRi-0008F1-Vw for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Dec 2022 14:38:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5oQC-0007zJ-7q; Thu, 15 Dec 2022 08:37:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5oQ2-0007sK-PG for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 08:37:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5oQ2-00061C-GM for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 08:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p5oQ2-0006C6-2P for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 08:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Dec 2022 13:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60015 X-GNU-PR-Package: emacs Original-Received: via spool by 60015-submit@debbugs.gnu.org id=B60015.167111139623795 (code B ref 60015); Thu, 15 Dec 2022 13:37:02 +0000 Original-Received: (at 60015) by debbugs.gnu.org; 15 Dec 2022 13:36:36 +0000 Original-Received: from localhost ([127.0.0.1]:43009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5oPb-0006Bj-IO for submit@debbugs.gnu.org; Thu, 15 Dec 2022 08:36:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5oPX-0006BZ-Ec for 60015@debbugs.gnu.org; Thu, 15 Dec 2022 08:36:34 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5oPR-0005po-SX; Thu, 15 Dec 2022 08:36:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=IV8GxMq9n3mpGfmHCm19/Em1vEjZiDYE6cNbeIl0nuM=; b=sEdhMeWfAxfM ZdwSiGfAu4Me0lS4wHX0WbtzXqcT5oQVei1H0CKPZvSWfgCuJ2KDT0BeGQBdL+R4nKUgItFCapGgA Qp5jXyPwJcweAdXEkc6VPkQ2IczZDb/j6h1ydU7FusK1MeGwVgGnku/NThiPvD3Ir+8AgnuwpPRv3 sJ+2OffC8lhHT+OgdugwCE4HmAu7tCRoCM+rErLdCKz8n962KsDlpE8glw2gjtE1VKHz69V9fFn/I gZC4sB/59a9XzztkEl/ziVePXcIn917G7kLidNjeYNdhyrbYdJHeXEB+LOUkW7FH/gxb4/CKqqPRJ OsJ6ubGISQNaR7SVx4Nmow==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5oPR-0004Gv-1B; Thu, 15 Dec 2022 08:36:25 -0500 In-Reply-To: <32f8777a-2bc3-961c-e773-46451f2b9282@gmx.at> (message from martin rudalics on Thu, 15 Dec 2022 11:18:15 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251090 Archived-At: > Date: Thu, 15 Dec 2022 11:18:15 +0100 > Cc: 60015@debbugs.gnu.org > From: martin rudalics > > > Here is a better test case. Please evaluate: > > > > (progn > > (keymap-global-set "C-c C-c" (lambda () (interactive) (message "abc\ndef"))) > > nil) > > > > Then the bug can be reproduced with just these keys: > > > > M-x > > C-x o > > C-c C-c > > > > Only the top line is displayed in the minibuffer. > > This is caused by resize_echo_area_exactly in xdisp.c. If you replace > > Lisp_Object resize_exactly = (minibuf_level == 0 ? Qt : Qnil); > > with > > Lisp_Object resize_exactly = Qt; > > the echo area gets resized. Are you sure this is the reason and the possible fix? The commentary to resize_echo_area_exactly says: /* Resize the echo area window to exactly the size needed for the currently displayed message, if there is one. If a mini-buffer is active, don't shrink it. */ which makes a lot of sense. And resize_mini_window, which does the job and accepts the argument you suggest to make Qt always, has this single place where it looks at that argument (called EXACT_P): if (EQ (Vresize_mini_windows, Qgrow_only)) { /* Let it grow only, until we display an empty message, in which case the window shrinks again. */ if (height > old_height) grow_mini_window (w, height - old_height); else if (height < old_height && (exact_p || BEGV == ZV)) shrink_mini_window (w); } So this argument cannot have any effect on enlarging the mini-window, only on shrinking it. Or am I missing something?