From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer Date: Sat, 17 Dec 2022 20:45:34 +0200 Message-ID: <837cyphnsh.fsf@gnu.org> References: <86y1rco5xe.fsf@mail.linkov.net> <83cz8oqybf.fsf@gnu.org> <86zgbsmpta.fsf@mail.linkov.net> <83a63sqvhq.fsf@gnu.org> <865yefw7o5.fsf@mail.linkov.net> <83r0x3nqq6.fsf@gnu.org> <86h6xzrxug.fsf@mail.linkov.net> <86mt7pgkzh.fsf@mail.linkov.net> <32f8777a-2bc3-961c-e773-46451f2b9282@gmx.at> <837cyslrfr.fsf@gnu.org> <83359gloyc.fsf@gnu.org> <7fdcca3f-ab71-fb91-990b-d708e585d5b7@gmx.at> <3c5cf7d7-d61f-ba61-8b3e-205b57775833@gmx.at> <831qp0lm62.fsf@gnu.org> <868rj6ylne.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1242"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rudalics@gmx.at, 60015-done@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 17 19:46:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p6cCL-0000Bd-0C for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Dec 2022 19:46:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6cCC-0005l6-Kp; Sat, 17 Dec 2022 13:46:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6cCA-0005kb-Rq for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 13:46:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6cCA-0007ey-KK for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 13:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p6cCA-0000Mu-4r for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 13:46:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Dec 2022 18:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 60015 X-GNU-PR-Package: emacs Mail-Followup-To: 60015@debbugs.gnu.org, eliz@gnu.org, juri@linkov.net Original-Received: via spool by 60015-done@debbugs.gnu.org id=D60015.16713027441406 (code D ref 60015); Sat, 17 Dec 2022 18:46:01 +0000 Original-Received: (at 60015-done) by debbugs.gnu.org; 17 Dec 2022 18:45:44 +0000 Original-Received: from localhost ([127.0.0.1]:57402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6cBs-0000Mc-Cu for submit@debbugs.gnu.org; Sat, 17 Dec 2022 13:45:44 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6cBr-0000MS-8y for 60015-done@debbugs.gnu.org; Sat, 17 Dec 2022 13:45:43 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6cBf-0007bE-TI; Sat, 17 Dec 2022 13:45:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Pr4JtBvge+zN64fRmJSEtzD4ZnKxPnjVRgQvouuGP4c=; b=To3Vza7STCLy SKlPNdFAmSwNTO07Rm7XEgMBKYNfgylzHEtXCtsuwqlvkkHiTzJfQvV0K4CWPK/DGRFvqGYSZSJPs VV7Y1uG1/NUU49G6yvbW7EdxbLCLUWLA3Dd3Nv1wvzm3hS7+P4pTZhV720WDA4IKgN/xd7X6Ornfu 2d7quxiU/ikT8/njtof5/UNfh3t6hVqDdAbBI7V3HPLMgQgewAT/q1M/o1nnYzXG+U0hm/N+px7jq JhYzTjvePo/yqa6jtnmK90M498NpzVqGOCgbdjt+ZSAYD36KodT9tRI2u295WesrurUGbHqlwivF7 1oq0WpFWERt08EeEbAO1rg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6cBc-0003wD-FE; Sat, 17 Dec 2022 13:45:31 -0500 In-Reply-To: <868rj6ylne.fsf@mail.linkov.net> (message from Juri Linkov on Sat, 17 Dec 2022 19:39:49 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251308 Archived-At: > From: Juri Linkov > Cc: martin rudalics , 60015@debbugs.gnu.org > Date: Sat, 17 Dec 2022 19:39:49 +0200 > > > Juri, does the patch below give good results? It's a bit of overkill, > > since the mini-window usually doesn't need any resizing, but maybe > > that is not too bad. > > > > If it seems to solve the problem, would you please run with this for a > > couple of weeks, and report back if you see any problems? If there > > are no problems, I'll then install this on the emacs-29 branch. > > > > diff --git a/src/xdisp.c b/src/xdisp.c > > index d14cd46..45da496 100644 > > --- a/src/xdisp.c > > +++ b/src/xdisp.c > > @@ -19429,6 +19429,13 @@ redisplay_window (Lisp_Object window, bool just_this_one_p) > > blank_row (w, row, y); > > goto finish_scroll_bars; > > } > > + else if (minibuf_level >= 1) > > + { > > + /* We could have a message produced by set-minibuffer-message > > + displayed in the mini-window as an overlay, so resize the > > + mini-window if needed. */ > > + resize_mini_window (w, false); > > + } > > I tested it for a while and see no problems with it. Thanks, installed on the emacs-29 branch, and closing this bug.