unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Michael Welsh Duggan <md5i@md5i.com>
Cc: 11199@debbugs.gnu.org
Subject: bug#11199: 24.0.95; killing right-to-left text at eob leads to inconsistent state
Date: Mon, 09 Apr 2012 15:34:40 +0300	[thread overview]
Message-ID: <8362d984nz.fsf@gnu.org> (raw)
In-Reply-To: <87zkal9jzx.fsf@maru.md5i.com>

> From: Michael Welsh Duggan <md5i@md5i.com>
> Cc: mituharu@math.s.chiba-u.ac.jp,  11199@debbugs.gnu.org
> Date: Mon, 09 Apr 2012 08:18:10 -0400
> 
> > === modified file 'src/xdisp.c'
> > --- src/xdisp.c	2012-03-31 19:30:53 +0000
> > +++ src/xdisp.c	2012-04-09 11:46:50 +0000
> > @@ -16602,7 +16602,15 @@ find_last_unchanged_at_beg_row (struct w
> >  	     continued.  */
> >  	  && !(MATRIX_ROW_END_CHARPOS (row) == first_changed_pos
> >  	       && (row->continued_p
> > -		   || row->exact_window_width_line_p)))
> > +		   || row->exact_window_width_line_p))
> > +	  /* If ROW->end is beyond ZV, then ROW->end is outdated and
> > +	     needs to be recomputed, so don't consider this row as
> > +	     unchanged.  This happens when the last line was
> > +	     bidi-reordered and was killed immediately before this
> > +	     redisplay cycle.  In that case, ROW->end stores the
> > +	     buffer position of the first visual-order character of
> > +	     the next row, which is now beyond ZV.  */
> > +	  && CHARPOS (row->end.pos) <= ZV)
> >  	row_found = row;
> >  
> >        /* Stop if last visible row.  */
> >
> 
> I can verify that this patch keeps the original recipe from causing
> Emacs to crash.  Everything looks good for now.

Thanks, I installed this as revision 107792 on the emacs-24 branch.  I
will wait for Yamamoto-san to confirm that this fixes his problem as
well, before I close this bug.

Thank you both for your great help in solving this bug.





  reply	other threads:[~2012-04-09 12:34 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-08  2:26 bug#11199: 24.0.95; killing right-to-left text at eob leads to inconsistent state YAMAMOTO Mitsuharu
2012-04-08  7:33 ` Eli Zaretskii
2012-04-08 18:28   ` Michael Welsh Duggan
2012-04-08 18:33     ` Michael Welsh Duggan
2012-04-08 20:03     ` Eli Zaretskii
2012-04-08 20:13       ` Eli Zaretskii
2012-04-08 20:19         ` Michael Welsh Duggan
2012-04-08 20:16       ` Michael Welsh Duggan
2012-04-08 20:20         ` Eli Zaretskii
2012-04-08 20:25           ` Michael Welsh Duggan
2012-04-08 20:37             ` Eli Zaretskii
2012-04-08 20:48               ` Eli Zaretskii
2012-04-08 21:01                 ` Michael Welsh Duggan
2012-04-08 21:10                   ` Eli Zaretskii
2012-04-08 21:17                     ` Michael Welsh Duggan
2012-04-09  6:24                       ` Eli Zaretskii
2012-04-08 20:49               ` Michael Welsh Duggan
2012-04-08 21:07                 ` Eli Zaretskii
2012-04-09  8:21                   ` YAMAMOTO Mitsuharu
2012-04-09  9:32                     ` Eli Zaretskii
2012-04-09  9:10             ` Eli Zaretskii
2012-04-09  9:48               ` YAMAMOTO Mitsuharu
2012-04-09 10:17                 ` Eli Zaretskii
2012-04-09 11:07                   ` Eli Zaretskii
2012-04-09 11:52                     ` Eli Zaretskii
2012-04-09 12:18                       ` Michael Welsh Duggan
2012-04-09 12:34                         ` Eli Zaretskii [this message]
2012-04-09 23:50                           ` YAMAMOTO Mitsuharu
2012-04-10  6:27                             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8362d984nz.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=11199@debbugs.gnu.org \
    --cc=md5i@md5i.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).