From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#11199: 24.0.95; killing right-to-left text at eob leads to inconsistent state Date: Mon, 09 Apr 2012 15:34:40 +0300 Message-ID: <8362d984nz.fsf@gnu.org> References: <83bon2ad9z.fsf@gnu.org> <8762dacc3w.fsf@maru.md5i.com> <831uny9ekk.fsf@gnu.org> <87ty0uasiq.fsf@maru.md5i.com> <83y5q67z7h.fsf@gnu.org> <87lim6as39.fsf@maru.md5i.com> <83d37h8e4u.fsf@gnu.org> <83aa2l8b0i.fsf@gnu.org> <838vi588ow.fsf@gnu.org> <837gxp86lp.fsf@gnu.org> <87zkal9jzx.fsf@maru.md5i.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: dough.gmane.org 1333975040 19490 80.91.229.3 (9 Apr 2012 12:37:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 9 Apr 2012 12:37:20 +0000 (UTC) Cc: 11199@debbugs.gnu.org To: Michael Welsh Duggan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 09 14:37:19 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SHDqR-00052r-4x for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Apr 2012 14:37:19 +0200 Original-Received: from localhost ([::1]:44336 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SHDqQ-0007Bj-CZ for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Apr 2012 08:37:18 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SHDqK-0007BM-6h for bug-gnu-emacs@gnu.org; Mon, 09 Apr 2012 08:37:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SHDqF-00070z-ES for bug-gnu-emacs@gnu.org; Mon, 09 Apr 2012 08:37:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SHDqF-00070c-AT for bug-gnu-emacs@gnu.org; Mon, 09 Apr 2012 08:37:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SHDr8-0007ag-32 for bug-gnu-emacs@gnu.org; Mon, 09 Apr 2012 08:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Apr 2012 12:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11199 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11199-submit@debbugs.gnu.org id=B11199.133397507329113 (code B ref 11199); Mon, 09 Apr 2012 12:38:02 +0000 Original-Received: (at 11199) by debbugs.gnu.org; 9 Apr 2012 12:37:53 +0000 Original-Received: from localhost ([127.0.0.1]:46426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHDqz-0007ZV-Bk for submit@debbugs.gnu.org; Mon, 09 Apr 2012 08:37:53 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:49931) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHDqv-0007ZK-1x for 11199@debbugs.gnu.org; Mon, 09 Apr 2012 08:37:50 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M2700700POC8O00@a-mtaout22.012.net.il> for 11199@debbugs.gnu.org; Mon, 09 Apr 2012 15:36:35 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.229.57.204]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M27004V9POYFYF1@a-mtaout22.012.net.il>; Mon, 09 Apr 2012 15:36:35 +0300 (IDT) In-reply-to: <87zkal9jzx.fsf@maru.md5i.com> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:58637 Archived-At: > From: Michael Welsh Duggan > Cc: mituharu@math.s.chiba-u.ac.jp, 11199@debbugs.gnu.org > Date: Mon, 09 Apr 2012 08:18:10 -0400 > > > === modified file 'src/xdisp.c' > > --- src/xdisp.c 2012-03-31 19:30:53 +0000 > > +++ src/xdisp.c 2012-04-09 11:46:50 +0000 > > @@ -16602,7 +16602,15 @@ find_last_unchanged_at_beg_row (struct w > > continued. */ > > && !(MATRIX_ROW_END_CHARPOS (row) == first_changed_pos > > && (row->continued_p > > - || row->exact_window_width_line_p))) > > + || row->exact_window_width_line_p)) > > + /* If ROW->end is beyond ZV, then ROW->end is outdated and > > + needs to be recomputed, so don't consider this row as > > + unchanged. This happens when the last line was > > + bidi-reordered and was killed immediately before this > > + redisplay cycle. In that case, ROW->end stores the > > + buffer position of the first visual-order character of > > + the next row, which is now beyond ZV. */ > > + && CHARPOS (row->end.pos) <= ZV) > > row_found = row; > > > > /* Stop if last visible row. */ > > > > I can verify that this patch keeps the original recipe from causing > Emacs to crash. Everything looks good for now. Thanks, I installed this as revision 107792 on the emacs-24 branch. I will wait for Yamamoto-san to confirm that this fixes his problem as well, before I close this bug. Thank you both for your great help in solving this bug.