unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: 11199@debbugs.gnu.org
Subject: bug#11199: 24.0.95; killing right-to-left text at eob leads to inconsistent state
Date: Mon, 09 Apr 2012 12:32:39 +0300	[thread overview]
Message-ID: <83bon18d3c.fsf@gnu.org> (raw)
In-Reply-To: <wl8vi58gdc.wl%mituharu@math.s.chiba-u.ac.jp>

> Date: Mon, 09 Apr 2012 17:21:51 +0900
> From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
> Cc: Michael Welsh Duggan <md5i@md5i.com>,
> 	11199@debbugs.gnu.org
> 
> It seems that row->end gets "out of sync" much earlier than C-k,
> actually just after C-x C-e in Step 4 in the original recipe.

Yes, that matches my observations, see my last mail today.

> It is
> set at the part you mentioned above in display_line:
> 
>  19473	  row->end = it->current;
> 
> and it->current has been updated by
> 
>  19379		  /* Consume the line end.  This skips over invisible lines.  */
>  19380		  set_iterator_to_next (it, 1);
> 
> Maybe set_iterator_to_next has skipped too much

Looks like it.  Can you trace through set_iterator_to_next and its
subroutines, and see why it does so?  One way of doing that is to put
a breakpoint in set_iterator_to_next conditioned by the value of point
(which is available as 'current_buffer->pt').  (If you don't condition
by value of point, you will hit the breakpoint too many times.)

> or another value should be set to row->end if the subsequent row
> starts with some right-to-left text?

No, row->end always preserves the last position information of the
display iterator, no matter if the text was or wasn't reordered.  The
correct operation of the display engine when rendering the next line
depends on that.





  reply	other threads:[~2012-04-09  9:32 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-08  2:26 bug#11199: 24.0.95; killing right-to-left text at eob leads to inconsistent state YAMAMOTO Mitsuharu
2012-04-08  7:33 ` Eli Zaretskii
2012-04-08 18:28   ` Michael Welsh Duggan
2012-04-08 18:33     ` Michael Welsh Duggan
2012-04-08 20:03     ` Eli Zaretskii
2012-04-08 20:13       ` Eli Zaretskii
2012-04-08 20:19         ` Michael Welsh Duggan
2012-04-08 20:16       ` Michael Welsh Duggan
2012-04-08 20:20         ` Eli Zaretskii
2012-04-08 20:25           ` Michael Welsh Duggan
2012-04-08 20:37             ` Eli Zaretskii
2012-04-08 20:48               ` Eli Zaretskii
2012-04-08 21:01                 ` Michael Welsh Duggan
2012-04-08 21:10                   ` Eli Zaretskii
2012-04-08 21:17                     ` Michael Welsh Duggan
2012-04-09  6:24                       ` Eli Zaretskii
2012-04-08 20:49               ` Michael Welsh Duggan
2012-04-08 21:07                 ` Eli Zaretskii
2012-04-09  8:21                   ` YAMAMOTO Mitsuharu
2012-04-09  9:32                     ` Eli Zaretskii [this message]
2012-04-09  9:10             ` Eli Zaretskii
2012-04-09  9:48               ` YAMAMOTO Mitsuharu
2012-04-09 10:17                 ` Eli Zaretskii
2012-04-09 11:07                   ` Eli Zaretskii
2012-04-09 11:52                     ` Eli Zaretskii
2012-04-09 12:18                       ` Michael Welsh Duggan
2012-04-09 12:34                         ` Eli Zaretskii
2012-04-09 23:50                           ` YAMAMOTO Mitsuharu
2012-04-10  6:27                             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bon18d3c.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=11199@debbugs.gnu.org \
    --cc=mituharu@math.s.chiba-u.ac.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).