unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ingo Lohmar <ingo.lohmar@posteo.net>
Cc: 47437-done@debbugs.gnu.org
Subject: bug#47437: 28.0.50; pulse-momentary-highlight-overlay breaks if background color is inherited
Date: Sun, 28 Mar 2021 15:31:31 +0300	[thread overview]
Message-ID: <835z1bo3x8.fsf@gnu.org> (raw)
In-Reply-To: <87czvks2kp.fsf@kenko.localhost.com> (message from Ingo Lohmar on Sat, 27 Mar 2021 22:34:46 +0100)

> From: Ingo Lohmar <ingo.lohmar@posteo.net>
> Date: Sat, 27 Mar 2021 22:34:46 +0100
> 
> 
> The bug surfaces after setting the pulse highlight face by inheriting
> from other faces (no explicit background attribute), for example like
> this:
> 
> (custom-set-faces
>  '(pulse-highlight-start-face ((t (:inherit highlight))) 'new))
> 
> I do this as I employ a restricted set of color faces from which all
> others inherit.  With the above setting, run `xref-find-definitions'
> (M-.) on an elisp symbol.  This triggers
> `pulse-momentary-highlight-overlay', which fails at
> 
>     (color-name-to-rgb
>      (face-background 'pulse-highlight-start-face))
> 
> because the background attribute is `nil'.  Adding the "inherit"
> argument works, at least in the above case:
> 
>     (color-name-to-rgb
>      (face-background 'pulse-highlight-start-face nil t))

Thanks, I made that change on master now, except that I used 'default'
instead of t, to make sure the returned value is always a color name.





  reply	other threads:[~2021-03-28 12:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-27 21:34 bug#47437: 28.0.50; pulse-momentary-highlight-overlay breaks if background color is inherited Ingo Lohmar
2021-03-28 12:31 ` Eli Zaretskii [this message]
     [not found]   ` <87a6qnsae0.fsf@kenko.localhost.com>
2021-03-28 13:26     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835z1bo3x8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=47437-done@debbugs.gnu.org \
    --cc=ingo.lohmar@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).