From: Eli Zaretskii <eliz@gnu.org>
To: Ingo Lohmar <ingo.lohmar@posteo.net>
Cc: 47437@debbugs.gnu.org
Subject: bug#47437: 28.0.50; pulse-momentary-highlight-overlay breaks if background color is inherited
Date: Sun, 28 Mar 2021 16:26:08 +0300 [thread overview]
Message-ID: <831rbzo1e7.fsf@gnu.org> (raw)
In-Reply-To: <87a6qnsae0.fsf@kenko.localhost.com> (message from Ingo Lohmar on Sun, 28 Mar 2021 14:58:15 +0200)
> From: Ingo Lohmar <ingo.lohmar@posteo.net>
> Date: Sun, 28 Mar 2021 14:58:15 +0200
>
> 1) I would have suggested to use 'default' myself, if the docstring of
> `face-background' were not (IMHO) misleading: The paragraph describing
> INHERIT (wrongly) suggested to me that giving a face would also
> disregard the :inherit attribute.
>
> The same applies to the other helper functions (`face-foreground' etc).
> The docstring of `face-attribute' is clearer ("further merged") about
> the fact that inherit is still followed in the non-t case.
>
> I suggest to amend the last sentence in the inherit paragraph of all
> these docstrings, from
>
> "If INHERIT is a face or a list of faces, then it is used to try to
> resolve an unspecified ..."
>
> to
>
> "If INHERIT is a face or a list of faces, then it is used to try to
> resolve a value that is still unspecified after considering the
> `:inherit' attribute."
I made a slightly different change (on the release branch), thanks.
> 2) There are two more instances of `face-background' in
> `pulse-reset-face' in the same file, one with a 't' INHERIT argument. I
> haven't tried to understand the details, but I strongly suspect they
> should get the 'default' argument as well.
I didn't see any places where a nil value could make a problem, so I
didn't change anything here. If you see any problems, please report
them.
prev parent reply other threads:[~2021-03-28 13:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 21:34 bug#47437: 28.0.50; pulse-momentary-highlight-overlay breaks if background color is inherited Ingo Lohmar
2021-03-28 12:31 ` Eli Zaretskii
[not found] ` <87a6qnsae0.fsf@kenko.localhost.com>
2021-03-28 13:26 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831rbzo1e7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=47437@debbugs.gnu.org \
--cc=ingo.lohmar@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).