From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47437: 28.0.50; pulse-momentary-highlight-overlay breaks if background color is inherited Date: Sun, 28 Mar 2021 15:31:31 +0300 Message-ID: <835z1bo3x8.fsf@gnu.org> References: <87czvks2kp.fsf@kenko.localhost.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21829"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47437-done@debbugs.gnu.org To: Ingo Lohmar Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 28 14:32:53 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lQUb6-0005az-Co for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Mar 2021 14:32:52 +0200 Original-Received: from localhost ([::1]:54460 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQUb5-000436-FV for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Mar 2021 08:32:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQUaJ-00042M-D0 for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 08:32:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33957) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQUaH-0005T3-Te for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 08:32:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lQUaH-000174-Qg for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 08:32:01 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Mar 2021 12:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 47437 X-GNU-PR-Package: emacs Mail-Followup-To: 47437@debbugs.gnu.org, eliz@gnu.org, ingo.lohmar@posteo.net Original-Received: via spool by 47437-done@debbugs.gnu.org id=D47437.16169347004243 (code D ref 47437); Sun, 28 Mar 2021 12:32:01 +0000 Original-Received: (at 47437-done) by debbugs.gnu.org; 28 Mar 2021 12:31:40 +0000 Original-Received: from localhost ([127.0.0.1]:45502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQUZv-00016N-QC for submit@debbugs.gnu.org; Sun, 28 Mar 2021 08:31:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQUZu-00016A-89 for 47437-done@debbugs.gnu.org; Sun, 28 Mar 2021 08:31:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51897) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQUZp-0005Dc-1c; Sun, 28 Mar 2021 08:31:33 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1657 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lQUZi-000662-1n; Sun, 28 Mar 2021 08:31:32 -0400 In-Reply-To: <87czvks2kp.fsf@kenko.localhost.com> (message from Ingo Lohmar on Sat, 27 Mar 2021 22:34:46 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203154 Archived-At: > From: Ingo Lohmar > Date: Sat, 27 Mar 2021 22:34:46 +0100 > > > The bug surfaces after setting the pulse highlight face by inheriting > from other faces (no explicit background attribute), for example like > this: > > (custom-set-faces > '(pulse-highlight-start-face ((t (:inherit highlight))) 'new)) > > I do this as I employ a restricted set of color faces from which all > others inherit. With the above setting, run `xref-find-definitions' > (M-.) on an elisp symbol. This triggers > `pulse-momentary-highlight-overlay', which fails at > > (color-name-to-rgb > (face-background 'pulse-highlight-start-face)) > > because the background attribute is `nil'. Adding the "inherit" > argument works, at least in the above case: > > (color-name-to-rgb > (face-background 'pulse-highlight-start-face nil t)) Thanks, I made that change on master now, except that I used 'default' instead of t, to make sure the returned value is always a color name.