From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: sbaugh@janestreet.com, 64088@debbugs.gnu.org
Subject: bug#64088: [PATCH] Make project-root for vc projects return an absolute path
Date: Sat, 17 Jun 2023 09:25:36 +0300 [thread overview]
Message-ID: <835y7msizj.fsf@gnu.org> (raw)
In-Reply-To: <7dc390c9-5888-ee7b-386e-21054ec9f2d6@gutov.dev> (message from Dmitry Gutov on Sat, 17 Jun 2023 05:43:58 +0300)
> Date: Sat, 17 Jun 2023 05:43:58 +0300
> Cc: 64088@debbugs.gnu.org
> From: Dmitry Gutov <dmitry@gutov.dev>
>
> On 16/06/2023 08:52, Eli Zaretskii wrote:
> >> One concrete bug
> >> caused by this is that (project-forget-project "~/some/path") would
> >> work but (project-forget-project "/home/user/some/path") would not.
> > That problem is simple to solve where it happens, no? That is,
> > project-forget-project should try looking not just for the literal
> > root, but also for its expanded and abbreviated forms, and that's all.
>
> Alternatively, we could force-convert it to one or the other form when
> saving a new value to the list. Then we'd only need to convert a
> searches value to one of the forms.
How do we know such conversion will not cause other similar problems?
IME, low-level functions should not make any assumptions about what
higher-level code will need. On the contrary, it's higher-level code
which knows what it needs that should do the conversions it needs.
next prev parent reply other threads:[~2023-06-17 6:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 20:48 bug#64088: [PATCH] Make project-root for vc projects return an absolute path Spencer Baugh
2023-06-16 5:52 ` Eli Zaretskii
2023-06-17 2:43 ` Dmitry Gutov
2023-06-17 6:25 ` Eli Zaretskii [this message]
2023-06-18 0:43 ` Dmitry Gutov
2023-06-17 2:47 ` Dmitry Gutov
2023-06-27 20:01 ` Spencer Baugh
2023-07-10 2:17 ` Dmitry Gutov
2023-07-10 23:45 ` Spencer Baugh
2023-08-12 0:45 ` Dmitry Gutov
2023-08-19 12:31 ` sbaugh
2023-08-19 12:57 ` sbaugh
2023-08-23 0:24 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835y7msizj.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=64088@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).