From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64088: [PATCH] Make project-root for vc projects return an absolute path Date: Sat, 17 Jun 2023 09:25:36 +0300 Message-ID: <835y7msizj.fsf@gnu.org> References: <838rckt0lz.fsf@gnu.org> <7dc390c9-5888-ee7b-386e-21054ec9f2d6@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12071"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@janestreet.com, 64088@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 17 08:26:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qAPOG-0002v6-RD for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Jun 2023 08:26:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qAPNt-0002pb-PY; Sat, 17 Jun 2023 02:26:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAPNq-0002pD-R3 for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2023 02:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qAPNq-0006KD-IP for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2023 02:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qAPNq-0005ju-E2 for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2023 02:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 06:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64088 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64088-submit@debbugs.gnu.org id=B64088.168698314622023 (code B ref 64088); Sat, 17 Jun 2023 06:26:02 +0000 Original-Received: (at 64088) by debbugs.gnu.org; 17 Jun 2023 06:25:46 +0000 Original-Received: from localhost ([127.0.0.1]:50749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAPNa-0005j8-3O for submit@debbugs.gnu.org; Sat, 17 Jun 2023 02:25:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAPNX-0005it-PL for 64088@debbugs.gnu.org; Sat, 17 Jun 2023 02:25:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAPNR-0006Ec-Us; Sat, 17 Jun 2023 02:25:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qbhl373jmUn+gI2fUlOjycz6lDzzIhNsUXu/i/Ljtxg=; b=RQzTXnJ4tOlS II4FNWyTFQAHLbUFL3m6+SG4P34Bpa4D/naRXkWMa0eiNR5ZFqzLtP+m+TpJjXweWG8SPNuNysBy2 0ytedARobJphg5oErsCXBm6g48OZVFzvAXrO/3masF2fDOklmh93R2ASf94OWHEjBUiKVgnd/7cKj RGWcZNk5vEwzGi17R+92zPI0OeKIRFaQfjVh2FcN2rKnxjuhNxhABbdpI8EShbrCc2OEcD+BTSSxh sCyG0zZFO9n9mCVdLoFOMY35BWZKzNurcFTQXrtG5BMRaeoZrdEIfRPYkZ6Ygff5pqyiTt/HE9lmS Azh5lokBzQ5eBuFVSp96uw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAPNR-0005Jx-EZ; Sat, 17 Jun 2023 02:25:37 -0400 In-Reply-To: <7dc390c9-5888-ee7b-386e-21054ec9f2d6@gutov.dev> (message from Dmitry Gutov on Sat, 17 Jun 2023 05:43:58 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263504 Archived-At: > Date: Sat, 17 Jun 2023 05:43:58 +0300 > Cc: 64088@debbugs.gnu.org > From: Dmitry Gutov > > On 16/06/2023 08:52, Eli Zaretskii wrote: > >> One concrete bug > >> caused by this is that (project-forget-project "~/some/path") would > >> work but (project-forget-project "/home/user/some/path") would not. > > That problem is simple to solve where it happens, no? That is, > > project-forget-project should try looking not just for the literal > > root, but also for its expanded and abbreviated forms, and that's all. > > Alternatively, we could force-convert it to one or the other form when > saving a new value to the list. Then we'd only need to convert a > searches value to one of the forms. How do we know such conversion will not cause other similar problems? IME, low-level functions should not make any assumptions about what higher-level code will need. On the contrary, it's higher-level code which knows what it needs that should do the conversions it needs.