unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dmitry@gutov.dev>
To: Spencer Baugh <sbaugh@janestreet.com>, 64088@debbugs.gnu.org
Subject: bug#64088: [PATCH] Make project-root for vc projects return an absolute path
Date: Sat, 17 Jun 2023 05:47:00 +0300	[thread overview]
Message-ID: <3c6078aa-4089-46fd-18bb-d92be101ca4f@gutov.dev> (raw)
In-Reply-To: <ierttv8fo56.fsf@janestreet.com>

On 15/06/2023 23:48, Spencer Baugh wrote:
> -          (setq project (list 'vc backend root))
> +          (setq project (list 'vc backend (expand-file-name root)))

Spec violated or not (like Eli said, abbreviated names are still 
absolute), we should probably try to fix this in another place, so that 
other backends (whatever external ones exist) don't have to worry about 
the distinction.

As you can see, in project-buffers, for example, we call expand-file-name.





  parent reply	other threads:[~2023-06-17  2:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-15 20:48 bug#64088: [PATCH] Make project-root for vc projects return an absolute path Spencer Baugh
2023-06-16  5:52 ` Eli Zaretskii
2023-06-17  2:43   ` Dmitry Gutov
2023-06-17  6:25     ` Eli Zaretskii
2023-06-18  0:43       ` Dmitry Gutov
2023-06-17  2:47 ` Dmitry Gutov [this message]
2023-06-27 20:01   ` Spencer Baugh
2023-07-10  2:17     ` Dmitry Gutov
2023-07-10 23:45       ` Spencer Baugh
2023-08-12  0:45         ` Dmitry Gutov
2023-08-19 12:31           ` sbaugh
2023-08-19 12:57             ` sbaugh
2023-08-23  0:24               ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c6078aa-4089-46fd-18bb-d92be101ca4f@gutov.dev \
    --to=dmitry@gutov.dev \
    --cc=64088@debbugs.gnu.org \
    --cc=sbaugh@janestreet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).