From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 22241@debbugs.gnu.org
Subject: bug#22241: 25.0.50; etags Ruby parser problems
Date: Thu, 04 Feb 2016 05:43:40 +0200 [thread overview]
Message-ID: <834mdpxhqr.fsf@gnu.org> (raw)
In-Reply-To: <56B28B91.4010706@yandex.ru> (message from Dmitry Gutov on Thu, 4 Feb 2016 02:21:53 +0300)
> Cc: 22241@debbugs.gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Thu, 4 Feb 2016 02:21:53 +0300
>
> One nitpick:
>
> attr_WHATEVER :foo, bar
>
> will generate the methods for 'foo', and whatever the value of bar is.
> But bar is not very likely to have the value :bar, so we should only
> generate the tags for 'foo'.
>
> IOW, skip the arguments that are not Ruby Symbols (don't start with a
> colon). The current implementation treats them the same.
Yes, because etags is not supposed to do sensible things with
syntactically incorrect programs.
I'm not sure I understand the rules, though: is the "no colon, don't
tag" rule valid for any symbol following the attr_WHATEVER, or is that
applicable only to the 2nd, 3rd, etc. symbols? IOW, what, if
anything, should be tagged here:
attr_reader foo
next prev parent reply other threads:[~2016-02-04 3:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-26 3:59 bug#22241: 25.0.50; etags Ruby parser problems Dmitry Gutov
2015-12-26 4:13 ` Dmitry Gutov
2015-12-26 4:34 ` Dmitry Gutov
2016-01-23 16:38 ` Eli Zaretskii
2016-01-23 18:23 ` Dmitry Gutov
2016-01-23 18:59 ` Eli Zaretskii
2016-01-23 19:29 ` Dmitry Gutov
2016-01-23 20:48 ` Eli Zaretskii
2016-01-23 21:43 ` Dmitry Gutov
2016-01-24 15:44 ` Eli Zaretskii
2016-01-30 12:21 ` Eli Zaretskii
2016-01-30 22:06 ` Dmitry Gutov
2016-01-31 3:37 ` Eli Zaretskii
2016-01-31 5:43 ` Dmitry Gutov
2016-01-31 18:11 ` Eli Zaretskii
2016-02-01 8:40 ` Dmitry Gutov
2016-02-02 18:16 ` Eli Zaretskii
2016-02-02 19:59 ` Dmitry Gutov
2016-02-03 16:26 ` Eli Zaretskii
2016-02-03 23:21 ` Dmitry Gutov
2016-02-04 3:43 ` Eli Zaretskii [this message]
2016-02-04 8:24 ` Dmitry Gutov
2016-02-04 17:24 ` Eli Zaretskii
2016-02-04 20:06 ` Dmitry Gutov
2016-01-31 18:01 ` Eli Zaretskii
2016-02-01 8:24 ` Dmitry Gutov
2016-02-02 18:13 ` Eli Zaretskii
2016-01-30 10:52 ` Eli Zaretskii
2016-01-30 16:43 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834mdpxhqr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=22241@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).