From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22241: 25.0.50; etags Ruby parser problems Date: Thu, 04 Feb 2016 05:43:40 +0200 Message-ID: <834mdpxhqr.fsf@gnu.org> References: <86r3i9hnbt.fsf@yandex.ru> <83si1o45g1.fsf@gnu.org> <56A3C53D.1050408@yandex.ru> <83oacc3yx7.fsf@gnu.org> <56A3D47E.3030802@yandex.ru> <83mvrw3tuj.fsf@gnu.org> <56A3F3F9.8030404@yandex.ru> <8360yj3rtf.fsf@gnu.org> <83k2mrw952.fsf@gnu.org> <56AD33CF.6060105@yandex.ru> <83h9hu4dy8.fsf@gnu.org> <56AD9EF3.3080104@yandex.ru> <83powh1uwh.fsf@gnu.org> <56AF1A0E.7080802@yandex.ru> <8360y7yo3y.fsf@gnu.org> <56B10AA7.5000103@yandex.ru> <83bn7xyd43.fsf@gnu.org> <56B28B91.4010706@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1454557522 3624 80.91.229.3 (4 Feb 2016 03:45:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 4 Feb 2016 03:45:22 +0000 (UTC) Cc: 22241@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 04 04:45:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aRAr0-0005WJ-1P for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Feb 2016 04:45:10 +0100 Original-Received: from localhost ([::1]:39322 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRAqy-00077J-L1 for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Feb 2016 22:45:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRAqv-00074s-AG for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2016 22:45:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRAqs-0000Nd-3e for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2016 22:45:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRAqs-0000NZ-0d for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2016 22:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aRAqr-0002Ve-Sh for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2016 22:45:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Feb 2016 03:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22241 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22241-submit@debbugs.gnu.org id=B22241.14545574489541 (code B ref 22241); Thu, 04 Feb 2016 03:45:01 +0000 Original-Received: (at 22241) by debbugs.gnu.org; 4 Feb 2016 03:44:08 +0000 Original-Received: from localhost ([127.0.0.1]:58615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRApz-0002To-Na for submit@debbugs.gnu.org; Wed, 03 Feb 2016 22:44:07 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:56146) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRApx-0002T7-Cg for 22241@debbugs.gnu.org; Wed, 03 Feb 2016 22:44:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRApo-0008Je-Fj for 22241@debbugs.gnu.org; Wed, 03 Feb 2016 22:43:59 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43254) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRApo-0008Ja-CW; Wed, 03 Feb 2016 22:43:56 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3721 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aRApn-00026A-Uu; Wed, 03 Feb 2016 22:43:56 -0500 In-reply-to: <56B28B91.4010706@yandex.ru> (message from Dmitry Gutov on Thu, 4 Feb 2016 02:21:53 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112369 Archived-At: > Cc: 22241@debbugs.gnu.org > From: Dmitry Gutov > Date: Thu, 4 Feb 2016 02:21:53 +0300 > > One nitpick: > > attr_WHATEVER :foo, bar > > will generate the methods for 'foo', and whatever the value of bar is. > But bar is not very likely to have the value :bar, so we should only > generate the tags for 'foo'. > > IOW, skip the arguments that are not Ruby Symbols (don't start with a > colon). The current implementation treats them the same. Yes, because etags is not supposed to do sensible things with syntactically incorrect programs. I'm not sure I understand the rules, though: is the "no colon, don't tag" rule valid for any symbol following the attr_WHATEVER, or is that applicable only to the 2nd, 3rd, etc. symbols? IOW, what, if anything, should be tagged here: attr_reader foo