From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 22241@debbugs.gnu.org
Subject: bug#22241: 25.0.50; etags Ruby parser problems
Date: Tue, 2 Feb 2016 22:59:35 +0300 [thread overview]
Message-ID: <56B10AA7.5000103@yandex.ru> (raw)
In-Reply-To: <8360y7yo3y.fsf@gnu.org>
On 02/02/2016 09:16 PM, Eli Zaretskii wrote:
>> So you would handle
>>
>> attr_WHATEVER :foo, :bar # comment
>>
>> and probably
>>
>> attr_WHATEVER :bar;
> OK, this is all implemented, except...
Thank you.
>> If there's a comma at the end of the current line, the argument list
>> continues on the next one.
>
> ...this. If supporting such split definitions is important, it will
> need a slightly more complex code.
It's basically a multiline function call. Not sure how frequently that
is used with attr_* in practice, but in our big project at work, just
one out of 190 attr_* declarations is multiline.
So, it happens, but in the vast majority of cases the arguments stay on
one line. Some projects (like Rails) choose to make several calls
instead, as a stylistic choice.
I can't really say yet if the lack of support for multiline calls is a
significant problem, but it is an omission.
Whether to implement it now, or close this bug and wait until another
bug report, is up to you.
>> .rb .ru .rbw Rakefile Thorfile
>
> Also done (and doing so exposed a real bug in etags).
Thanks! Looks good.
next prev parent reply other threads:[~2016-02-02 19:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-26 3:59 bug#22241: 25.0.50; etags Ruby parser problems Dmitry Gutov
2015-12-26 4:13 ` Dmitry Gutov
2015-12-26 4:34 ` Dmitry Gutov
2016-01-23 16:38 ` Eli Zaretskii
2016-01-23 18:23 ` Dmitry Gutov
2016-01-23 18:59 ` Eli Zaretskii
2016-01-23 19:29 ` Dmitry Gutov
2016-01-23 20:48 ` Eli Zaretskii
2016-01-23 21:43 ` Dmitry Gutov
2016-01-24 15:44 ` Eli Zaretskii
2016-01-30 12:21 ` Eli Zaretskii
2016-01-30 22:06 ` Dmitry Gutov
2016-01-31 3:37 ` Eli Zaretskii
2016-01-31 5:43 ` Dmitry Gutov
2016-01-31 18:11 ` Eli Zaretskii
2016-02-01 8:40 ` Dmitry Gutov
2016-02-02 18:16 ` Eli Zaretskii
2016-02-02 19:59 ` Dmitry Gutov [this message]
2016-02-03 16:26 ` Eli Zaretskii
2016-02-03 23:21 ` Dmitry Gutov
2016-02-04 3:43 ` Eli Zaretskii
2016-02-04 8:24 ` Dmitry Gutov
2016-02-04 17:24 ` Eli Zaretskii
2016-02-04 20:06 ` Dmitry Gutov
2016-01-31 18:01 ` Eli Zaretskii
2016-02-01 8:24 ` Dmitry Gutov
2016-02-02 18:13 ` Eli Zaretskii
2016-01-30 10:52 ` Eli Zaretskii
2016-01-30 16:43 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B10AA7.5000103@yandex.ru \
--to=dgutov@yandex.ru \
--cc=22241@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).