bug#65487: 30.0.50; [PATCH] Fix 'makefile-browser-client' variable initialization

bug#65487: 30.0.50; [PATCH] Fix 'makefile-browser-client' variable initialization

[Christoph via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

Hi,

while browsing the sources of `make-mode', I noticed that the variable
initialization of `makefile-browser-client' is wrong. It is
initialized with its documentation string.  This is not a really a
problem, the makefile browser still works, but the documentation
string is lost as soon as the browser is opened once.

-- Christoph

[-- Attachment #2: 0001-Fix-makefile-browser-client-variable-initialization.patch --]
[-- Type: text/x-patch, Size: 948 bytes --]

From 768e48e58a661bd045a25dacbebccdb8cb26dd85 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christoph=20G=C3=B6ttschkes?= <just.mychris@googlemail.com>
Date: Wed, 23 Aug 2023 19:34:14 +0200
Subject: [PATCH] Fix 'makefile-browser-client' variable initialization

* lisp/progmodes/make-mode.el (makefile-browser-client):
Initialize to nil
---
 lisp/progmodes/make-mode.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/progmodes/make-mode.el b/lisp/progmodes/make-mode.el
index 017a551bc05..ff2aa137813 100644
--- a/lisp/progmodes/make-mode.el
+++ b/lisp/progmodes/make-mode.el
@@ -695,7 +695,7 @@ makefile-macro-table
   "Table of all macro names known for this buffer.")
 (put 'makefile-macro-table 'risky-local-variable t)
 
-(defvar makefile-browser-client
+(defvar makefile-browser-client nil
   "A buffer in Makefile mode that is currently using the browser.")
 
 (defvar makefile-browser-selection-vector nil)
-- 
2.42.0

bug#65487: 30.0.50; [PATCH] Fix 'makefile-browser-client' variable initialization

[Eli Zaretskii]

> Date: Wed, 23 Aug 2023 19:45:21 +0200
> From:  Christoph via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> while browsing the sources of `make-mode', I noticed that the variable
> initialization of `makefile-browser-client' is wrong. It is
> initialized with its documentation string.  This is not a really a
> problem, the makefile browser still works, but the documentation
> string is lost as soon as the browser is opened once.

Thanks, installed on the emacs-29 branch, and closing the bug.

(It amazes me how such a glaring mistake could go undetected since
1992.)

bug#65487: 30.0.50; [PATCH] Fix 'makefile-browser-client' variable initialization

[Stefan Kangas]

> (It amazes me how such a glaring mistake could go undetected since
> 1992.)

It might have something to do with this comment in that file:

;; * Consider removing browser mode.  It seems useless.

Also see Bug#58848: "Make makefile browser mode obsolete?".