unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Christoph via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 65487@debbugs.gnu.org
Subject: bug#65487: 30.0.50; [PATCH] Fix 'makefile-browser-client' variable initialization
Date: Wed, 23 Aug 2023 19:45:21 +0200	[thread overview]
Message-ID: <CAK9rt1ptPO4Xphna1w7HTQWs5ZY4G3LwLyNyobACUGOGO0Vn_g@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

Hi,

while browsing the sources of `make-mode', I noticed that the variable
initialization of `makefile-browser-client' is wrong. It is
initialized with its documentation string.  This is not a really a
problem, the makefile browser still works, but the documentation
string is lost as soon as the browser is opened once.

-- Christoph

[-- Attachment #2: 0001-Fix-makefile-browser-client-variable-initialization.patch --]
[-- Type: text/x-patch, Size: 948 bytes --]

From 768e48e58a661bd045a25dacbebccdb8cb26dd85 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christoph=20G=C3=B6ttschkes?= <just.mychris@googlemail.com>
Date: Wed, 23 Aug 2023 19:34:14 +0200
Subject: [PATCH] Fix 'makefile-browser-client' variable initialization

* lisp/progmodes/make-mode.el (makefile-browser-client):
Initialize to nil
---
 lisp/progmodes/make-mode.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/progmodes/make-mode.el b/lisp/progmodes/make-mode.el
index 017a551bc05..ff2aa137813 100644
--- a/lisp/progmodes/make-mode.el
+++ b/lisp/progmodes/make-mode.el
@@ -695,7 +695,7 @@ makefile-macro-table
   "Table of all macro names known for this buffer.")
 (put 'makefile-macro-table 'risky-local-variable t)
 
-(defvar makefile-browser-client
+(defvar makefile-browser-client nil
   "A buffer in Makefile mode that is currently using the browser.")
 
 (defvar makefile-browser-selection-vector nil)
-- 
2.42.0


             reply	other threads:[~2023-08-23 17:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-23 17:45 Christoph via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-08-24  7:25 ` bug#65487: 30.0.50; [PATCH] Fix 'makefile-browser-client' variable initialization Eli Zaretskii
2023-08-24 21:01   ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK9rt1ptPO4Xphna1w7HTQWs5ZY4G3LwLyNyobACUGOGO0Vn_g@mail.gmail.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=65487@debbugs.gnu.org \
    --cc=just.mychris@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).