From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#24745: 25.1.50; whitespace.el: fix beginning/end of buffer checks Date: Tue, 25 Oct 2016 02:36:59 +0300 Message-ID: <83402aab-73d0-eeae-1df1-c717caf198ba@yandex.ru> References: <87pomv6w1h.fsf@sc3d.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1477352304 14566 195.159.176.226 (24 Oct 2016 23:38:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 24 Oct 2016 23:38:24 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 Cc: 24745@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 25 01:38:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byoon-0002gB-At for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Oct 2016 01:38:13 +0200 Original-Received: from localhost ([::1]:50778 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byoop-0002Qb-Ew for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Oct 2016 19:38:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byooj-0002QU-4P for bug-gnu-emacs@gnu.org; Mon, 24 Oct 2016 19:38:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byoog-0001Yv-2A for bug-gnu-emacs@gnu.org; Mon, 24 Oct 2016 19:38:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40145) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1byoof-0001YQ-TW for bug-gnu-emacs@gnu.org; Mon, 24 Oct 2016 19:38:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1byooc-0004xC-Dc for bug-gnu-emacs@gnu.org; Mon, 24 Oct 2016 19:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Oct 2016 23:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24745 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24745-submit@debbugs.gnu.org id=B24745.147735222918975 (code B ref 24745); Mon, 24 Oct 2016 23:38:02 +0000 Original-Received: (at 24745) by debbugs.gnu.org; 24 Oct 2016 23:37:09 +0000 Original-Received: from localhost ([127.0.0.1]:55542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byonk-0004vz-PL for submit@debbugs.gnu.org; Mon, 24 Oct 2016 19:37:08 -0400 Original-Received: from mail-wm0-f67.google.com ([74.125.82.67]:36665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byonj-0004vX-8U for 24745@debbugs.gnu.org; Mon, 24 Oct 2016 19:37:07 -0400 Original-Received: by mail-wm0-f67.google.com with SMTP id c78so1033938wme.3 for <24745@debbugs.gnu.org>; Mon, 24 Oct 2016 16:37:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DrOnrzB4n+QzJKQ0IiVx7Tpm4WpYdAmV7XjWX+HA1cE=; b=GAjVnsWQa5n67QJFJPtKDPjzqBeSrpL5E+7lEhnpvNeynUyY1tiDkKW0j1hnaEZXBO nPT5zvWZaDs+cmgBYfRUEQGUOINXj+2Y6qpPVWYU+r7j2Joep1LPiT9Obj8kXUUQKNMI eRH4BuPSRrJi9CGs3c13MtvW01tyOETHG8Z2YaoPNM1Y4SQk3jKdxav4YuCAhgFCdS+v KjYa4olkyqRp1QWIwDEFF4mhDYOgBct6wqHqz4dWPBD7NqsaJLrIoB7VsXP4jtVyYdHY /+lL3nd5pgc/vVhBkt2MffDYQowlUQu+ml3PBThTGGVIaaoBhOEOfYmIc/i3GqIwMTp5 yTlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DrOnrzB4n+QzJKQ0IiVx7Tpm4WpYdAmV7XjWX+HA1cE=; b=J4tiEIqIqq2wxMtr9Lw3BAdvvcYKiXGIaaz4YICrigP+9WAJM8g15HS/PvCBuoY3U5 iJiYNyfS4lNjOaUI5rAf+DWc55IE/ra4c5Z1n9e61VyiT10EJJIPYRqwx87E0EyTz7aG hIhi7468pBjLEvr/SiC2oEFvU1eohpvF4GwKGk0siibPI8XU+9PY5qJ3r/3wHjQfy2gZ PsYDsJiZBT7opKloRxcOt5D/4VEftgFe0N6hcH9jKmzLKnmynQYNYCXX4uR+l2yjtE4I IMOobt6PYfIaXMMSIVM19zPI4zT0xF4W8KpgBKktSwuv9tCl2xeJMZxxxZMyJFY08dam HH7g== X-Gm-Message-State: ABUngvdeHJ69ucLbTfuwZdcHbZ7XoJ4uQMNToCsL36hm1WNrdUorVDKu/KhOh2ssX/Iagg== X-Received: by 10.28.25.134 with SMTP id 128mr166801wmz.99.1477352221567; Mon, 24 Oct 2016 16:37:01 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id 71sm360870wmo.7.2016.10.24.16.37.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Oct 2016 16:37:01 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124982 Archived-At: On 21.10.2016 17:52, Reuben Thomas wrote: > emacs -Q > > Open a new buffer > > Type: SPC foo > > Then, whitespace-report will show an X in the second column (problems > detected) for "Empty lines at end of buffer". Thanks. I get it now. A few comments on the patches themselves: - "remove duplicate documentation from the Commentary" sounds fine to me, but maybe we should leave something in its stead. The first part can be replaced with a reference to the `whitespace-style' docstring. The second one... is it really that out of date? The list of variables seems like it can be useful. - The commit messages don't follow the ChangeLog format, see https://www.gnu.org/prep/standards/html_node/Change-Logs.html, or simply the existing commit messages.