unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 45737@debbugs.gnu.org
Subject: bug#45737: 27.1.50; Assertion failure in window_box_height
Date: Sat, 09 Jan 2021 12:00:50 +0200	[thread overview]
Message-ID: <8335zaig4t.fsf@gnu.org> (raw)
In-Reply-To: <2fcf7ec9-8b85-e81f-6ae3-9d08abda8b3f@gmx.at> (message from martin rudalics on Sat, 9 Jan 2021 10:33:02 +0100)

> From: martin rudalics <rudalics@gmx.at>
> Date: Sat, 9 Jan 2021 10:33:02 +0100
> 
> (progn
>    (tab-line-mode)
>    (split-window (split-window) nil t)
>    (split-window)
>    (split-window (split-window nil nil t) nil t))
> 
> and resizing the frame by dragging its lower right corner with the mouse
> to very small rectangles I can trigger the following assertion failure:
> 
> ../../src/xdisp.c:1170: Emacs fatal error: assertion failed: height >= 0
> [...]
> Lisp Backtrace:
> "redisplay_internal (C function)" (0x0)
> (gdb) frame 2
> #2  0x0000000000458382 in window_box_height (w=0x149d100) at ../../src/xdisp.c:1170
> 1170	  eassert (height >= 0);
> (gdb) p height
> $2 = -54
> (gdb)
> 
> indicates that the total height of one of the windows dropped to -54
> pixels.  The problematic code is in 'window-sizable' which is not
> prepared for the case that window sizes can drop below their minimum
> size, something which can happen when a frame with many windows is made
> very small.  I propose the attached patch to fix this.  OK to install?

What happens in the above scenario with your patch installed?





  reply	other threads:[~2021-01-09 10:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-09  9:33 bug#45737: 27.1.50; Assertion failure in window_box_height martin rudalics
2021-01-09 10:00 ` Eli Zaretskii [this message]
2021-01-09 10:28   ` martin rudalics
2021-01-09 11:43     ` Eli Zaretskii
2021-01-09 17:06       ` martin rudalics
2021-01-09 17:25         ` martin rudalics
2021-01-09 17:49         ` Eli Zaretskii
2021-01-09 18:48           ` martin rudalics
2021-01-09 19:02             ` Eli Zaretskii
2021-01-10 16:06               ` martin rudalics
2022-02-07  1:05 ` Lars Ingebrigtsen
2022-02-07  8:57   ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8335zaig4t.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=45737@debbugs.gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).