unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 45737@debbugs.gnu.org
Subject: bug#45737: 27.1.50; Assertion failure in window_box_height
Date: Sat, 9 Jan 2021 18:06:53 +0100	[thread overview]
Message-ID: <48610ec3-59d8-575f-4360-598077630266@gmx.at> (raw)
In-Reply-To: <83zh1igwt0.fsf@gnu.org>

 > So the frame will resize as result dragging by mouse, but the
 > mini-window will not be visible?

Right.  With our gtk size hints, for example, we set

#define FRAME_TEXT_LINES_TO_PIXEL_HEIGHT(f, lines) \
   ((lines) * FRAME_LINE_HEIGHT (f)		   \
    + FRAME_TOP_MARGIN_HEIGHT (f)		   \
    + FRAME_SCROLL_BAR_HEIGHT (f)		   \
    + 2 * FRAME_INTERNAL_BORDER_WIDTH (f))

   base_height = FRAME_TEXT_LINES_TO_PIXEL_HEIGHT (f, 1)
     + FRAME_MENUBAR_HEIGHT (f) + FRAME_TOOLBAR_HEIGHT (f);

so we pretend that tab, menu and scroll bar, internal border and one
text line remain visible.  With the earlier recipe I get one text line
for the topmost normal window(s).  With

(progn
   (ruler-mode)
   (tab-line-mode)
   (horizontal-scroll-bar-mode)
   (split-window (split-window) nil t)
   (split-window)
   (split-window (split-window nil nil t) nil t))

the smallest frame shows the normal windows with a tab line and a ruler,
apparently stealing the space from the scroll bar.  The mini window
never shows up in practice.

 > If that is the effect, then I'm okay with installing this on emacs-27,
 > but I wonder whether we could do better on master, so as to ensure
 > that at least one screen line of the mini-window is still visible?

That would be better indeed.  But I suppose this would require to
implement zero-height windows, something you didn't like when we
discussed it about a year ago.

Alternatively, we (maybe) could set our size hints in a way that all
windows can be shown but maybe people wouldn't like it and on Windows
there's no way to do that without frames snapping back.

 > Btw, is this issue new in Emacs 27, or did it exist before?

New because tab lines didn't exist before Emacs 27.  And I couldn't
reproduce it with the ruler - maybe because it never wanted to write
something into the echo area.

martin





  reply	other threads:[~2021-01-09 17:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-09  9:33 bug#45737: 27.1.50; Assertion failure in window_box_height martin rudalics
2021-01-09 10:00 ` Eli Zaretskii
2021-01-09 10:28   ` martin rudalics
2021-01-09 11:43     ` Eli Zaretskii
2021-01-09 17:06       ` martin rudalics [this message]
2021-01-09 17:25         ` martin rudalics
2021-01-09 17:49         ` Eli Zaretskii
2021-01-09 18:48           ` martin rudalics
2021-01-09 19:02             ` Eli Zaretskii
2021-01-10 16:06               ` martin rudalics
2022-02-07  1:05 ` Lars Ingebrigtsen
2022-02-07  8:57   ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48610ec3-59d8-575f-4360-598077630266@gmx.at \
    --to=rudalics@gmx.at \
    --cc=45737@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).