From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#45946: [PATCH] Re: bug#45946: 28.0.50; hl-line-sticky-flag not working Date: Sat, 23 Jan 2021 10:10:47 +0200 Message-ID: <8335ys5b08.fsf@gnu.org> References: <83bldi74yn.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10266"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45946@debbugs.gnu.org To: Gabriel do Nascimento Ribeiro Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 23 09:11:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3E0j-0002aB-K6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Jan 2021 09:11:09 +0100 Original-Received: from localhost ([::1]:33592 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3E0i-0000vO-8K for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Jan 2021 03:11:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59010) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3E0c-0000vG-OS for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 03:11:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50300) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l3E0c-000105-HA for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 03:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l3E0c-0002go-Bh for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 03:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Jan 2021 08:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45946 X-GNU-PR-Package: emacs Original-Received: via spool by 45946-submit@debbugs.gnu.org id=B45946.161138945510323 (code B ref 45946); Sat, 23 Jan 2021 08:11:02 +0000 Original-Received: (at 45946) by debbugs.gnu.org; 23 Jan 2021 08:10:55 +0000 Original-Received: from localhost ([127.0.0.1]:33613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3E0U-0002gR-VW for submit@debbugs.gnu.org; Sat, 23 Jan 2021 03:10:55 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3E0T-0002gD-8V for 45946@debbugs.gnu.org; Sat, 23 Jan 2021 03:10:53 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37405) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3E0M-0000uB-S2; Sat, 23 Jan 2021 03:10:47 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2181 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l3E0M-00064c-8S; Sat, 23 Jan 2021 03:10:46 -0500 In-Reply-To: (message from Gabriel do Nascimento Ribeiro on Fri, 22 Jan 2021 23:22:21 -0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198422 Archived-At: > From: Gabriel do Nascimento Ribeiro > Date: Fri, 22 Jan 2021 23:22:21 -0300 > > > While at that, would it be possible to fix some code there that I at > > least consider strange? E.g., it calls delete-overlay, but doesn't > > assign nil to the variable, so the overlayp predicate still returns > > non-nil for the resulting invalid overlay. Also, it puts 2 functions > > on the post-command-hook, but it looks like the code subtly depends on > > the order of their execution (should hl-line-highlight run before or > > after hl-line-maybe-unhighlight?). > > Hi Eli, > > Thanks for your suggestions. Please find attached a new patch that uses > a single post-command-hook function and some other minor changes. The > original issue is fixed. Thanks, this LGTM, but could you please accompany the changes with the ChangeLog-style commit log message (see CONTRIBUTE about the details)? Also, this patch is close to the limit that we can accept without copyright assignment. So I'd suggest that you start the legal paperwork rolling at this time, to allow us to accept your future contributions. Would you like me to send to you the legal form to fill?