* bug#58957: [PATCH] Improve Brahmi composition rules.
@ 2022-11-02 2:41 समीर सिंह Sameer Singh
2022-11-02 2:44 ` समीर सिंह Sameer Singh
0 siblings, 1 reply; 8+ messages in thread
From: समीर सिंह Sameer Singh @ 2022-11-02 2:41 UTC (permalink / raw)
To: 58957
[-- Attachment #1: Type: text/plain, Size: 243 bytes --]
The present composition rules for Brahmi have a bug where the virama is not
composed with the consonants, I have fixed that now. I have also added
support for composing velar and bilabial fricatives in Brahmi.
Please review the patch.
Thanks
[-- Attachment #2: Type: text/html, Size: 314 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#58957: [PATCH] Improve Brahmi composition rules.
2022-11-02 2:41 bug#58957: [PATCH] Improve Brahmi composition rules समीर सिंह Sameer Singh
@ 2022-11-02 2:44 ` समीर सिंह Sameer Singh
2022-11-02 12:32 ` Eli Zaretskii
2022-12-11 10:39 ` Eli Zaretskii
0 siblings, 2 replies; 8+ messages in thread
From: समीर सिंह Sameer Singh @ 2022-11-02 2:44 UTC (permalink / raw)
To: 58957
[-- Attachment #1.1: Type: text/plain, Size: 368 bytes --]
On Wed, Nov 2, 2022 at 8:12 AM समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
wrote:
> The present composition rules for Brahmi have a bug where the virama is
> not composed with the consonants, I have fixed that now. I have also added
> support for composing velar and bilabial fricatives in Brahmi.
>
> Please review the patch.
> Thanks
>
[-- Attachment #1.2: Type: text/html, Size: 703 bytes --]
[-- Attachment #2: 0001-lisp-language-indian.el-Improve-Brahmi-composition-r.patch --]
[-- Type: text/x-patch, Size: 3390 bytes --]
From 0c4329edef9577d808e0a9c6d87b9e08e3b96356 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0=20=E0=A4=B8=E0=A4=BF?=
=?UTF-8?q?=E0=A4=82=E0=A4=B9=20Sameer=20Singh?= <lumarzeli30@gmail.com>
Date: Wed, 2 Nov 2022 08:05:44 +0530
Subject: [PATCH] * lisp/language/indian.el: Improve Brahmi composition rules.
(bug#58957)
---
lisp/language/indian.el | 42 ++++++++++++++++++++++++++++-------------
1 file changed, 29 insertions(+), 13 deletions(-)
diff --git a/lisp/language/indian.el b/lisp/language/indian.el
index 4994cfdc7a..f70f7fcce1 100644
--- a/lisp/language/indian.el
+++ b/lisp/language/indian.el
@@ -552,24 +552,40 @@ malayalam-composable-pattern
char-script-table))
;; Brahmi composition rules
-(let ((consonant "[\U00011013-\U00011034]")
- (non-consonant "[^\U00011013-\U00011034\U00011046\U0001107F]")
- (vowel "[\U00011038-\U00011045]")
- (numeral "[\U00011052-\U00011065]")
- (multiplier "[\U00011064\U00011065]")
- (virama "\U00011046")
- (number-joiner "\U0001107F"))
+(let ((consonant "[\x11013-\x11037\x11075]")
+ (independent-vowel "[\x11005-\x11012\x11071\x11072]")
+ (vowel "[\x11038-\x11045\x11073\x11074]")
+ (nasal "[\x11000\x11001]")
+ (virama "\x11046")
+ (jivhamuliya "\x11003")
+ (upadhmaniya "\x11004")
+ (ka-kha "[\x11013\x11014]")
+ (pa-pha "[\x11027\x11028]")
+ (number-joiner "\x1107F")
+ (numeral "[\x11052-\x11065]")
+ (multiplier "[\x11064\x11065]"))
(set-char-table-range composition-function-table
- '(#x11046 . #x11046)
+ '(#x11046 . #x11046)
(list (vector
- ;; Consonant conjuncts
- (concat consonant "\\(?:" virama consonant "\\)+"
- vowel "?")
+ ;; Consonant based syllables
+ (concat consonant "\\(?:" virama consonant
+ "\\)*\\(?:" virama "\\|" vowel "*"
+ nasal "?\\)")
1 'font-shape-gstring)
(vector
- ;; Vowelless consonants
- (concat consonant virama non-consonant)
+ ;; Vowel based syllables
+ (concat independent-vowel virama "?" vowel "?" nasal "?")
1 'font-shape-gstring)))
+ (set-char-table-range composition-function-table
+ '(#x11003 . #x11004)
+ (list (vector
+ ;; Velar fricative
+ (concat jivhamuliya ka-kha "?")
+ 0 'font-shape-gstring)
+ (vector
+ ;; Bilabial fricative
+ (concat upadhmaniya pa-pha "?")
+ 0 'font-shape-gstring)))
(set-char-table-range composition-function-table
'(#x1107F . #x1107F)
(list (vector
--
2.37.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* bug#58957: [PATCH] Improve Brahmi composition rules.
2022-11-02 2:44 ` समीर सिंह Sameer Singh
@ 2022-11-02 12:32 ` Eli Zaretskii
2022-11-02 14:57 ` समीर सिंह Sameer Singh
2022-12-11 10:39 ` Eli Zaretskii
1 sibling, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2022-11-02 12:32 UTC (permalink / raw)
To: समीर सिंह Sameer Singh
Cc: 58957
> From: समीर सिंह Sameer Singh
> <lumarzeli30@gmail.com>
> Date: Wed, 2 Nov 2022 08:14:09 +0530
>
> On Wed, Nov 2, 2022 at 8:12 AM समीर सिंह Sameer Singh <lumarzeli30@gmail.com> wrote:
>
> The present composition rules for Brahmi have a bug where the virama is not composed with the
> consonants, I have fixed that now. I have also added support for composing velar and bilabial fricatives in
> Brahmi.
>
> Please review the patch.
Thanks.
Should we perhaps introduce tests for compositions? For example, I
guess you found the problems with the current rules by examining the
display of some sequences of characters, so why not add a test that
would make sure we never again break those composable sequences?
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#58957: [PATCH] Improve Brahmi composition rules.
2022-11-02 12:32 ` Eli Zaretskii
@ 2022-11-02 14:57 ` समीर सिंह Sameer Singh
2022-11-24 19:40 ` Stefan Kangas
0 siblings, 1 reply; 8+ messages in thread
From: समीर सिंह Sameer Singh @ 2022-11-02 14:57 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 58957
[-- Attachment #1: Type: text/plain, Size: 1360 bytes --]
>
> Should we perhaps introduce tests for compositions? For example, I
> guess you found the problems with the current rules by examining the
> display of some sequences of characters, so why not add a test that
> would make sure we never again break those composable sequences?
Yes, that would be a good idea.
How should I start? Are there some pre-existing examples that checks for
composition,
or even a manual that describes how to write a test?
Thanks
On Wed, Nov 2, 2022 at 6:02 PM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: समीर सिंह Sameer Singh
> > <lumarzeli30@gmail.com>
> > Date: Wed, 2 Nov 2022 08:14:09 +0530
> >
> > On Wed, Nov 2, 2022 at 8:12 AM समीर सिंह Sameer Singh <
> lumarzeli30@gmail.com> wrote:
> >
> > The present composition rules for Brahmi have a bug where the virama is
> not composed with the
> > consonants, I have fixed that now. I have also added support for
> composing velar and bilabial fricatives in
> > Brahmi.
> >
> > Please review the patch.
>
> Thanks.
>
> Should we perhaps introduce tests for compositions? For example, I
> guess you found the problems with the current rules by examining the
> display of some sequences of characters, so why not add a test that
> would make sure we never again break those composable sequences?
>
[-- Attachment #2: Type: text/html, Size: 2029 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#58957: [PATCH] Improve Brahmi composition rules.
2022-11-02 14:57 ` समीर सिंह Sameer Singh
@ 2022-11-24 19:40 ` Stefan Kangas
0 siblings, 0 replies; 8+ messages in thread
From: Stefan Kangas @ 2022-11-24 19:40 UTC (permalink / raw)
To: समीर सिंह Sameer Singh
Cc: Eli Zaretskii, 58957
समीर सिंह Sameer Singh <lumarzeli30@gmail.com> writes:
> Should we perhaps introduce tests for compositions? For example, I
> guess you found the problems with the current rules by examining the
> display of some sequences of characters, so why not add a test that
> would make sure we never again break those composable sequences?
>
> Yes, that would be a good idea.
> How should I start? Are there some pre-existing examples that checks for
> composition,
> or even a manual that describes how to write a test?
We basically have the code in test/, and the `ert' info manual.
Evaluate this to open it:
(info "(ert) Top")
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#58957: [PATCH] Improve Brahmi composition rules.
2022-11-02 2:44 ` समीर सिंह Sameer Singh
2022-11-02 12:32 ` Eli Zaretskii
@ 2022-12-11 10:39 ` Eli Zaretskii
2022-12-14 14:48 ` समीर सिंह Sameer Singh
1 sibling, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2022-12-11 10:39 UTC (permalink / raw)
To: समीर सिंह Sameer Singh
Cc: 58957-done
> From: समीर सिंह Sameer Singh
> <lumarzeli30@gmail.com>
> Date: Wed, 2 Nov 2022 08:14:09 +0530
>
> On Wed, Nov 2, 2022 at 8:12 AM समीर सिंह Sameer Singh <lumarzeli30@gmail.com> wrote:
>
> The present composition rules for Brahmi have a bug where the virama is not composed with the
> consonants, I have fixed that now. I have also added support for composing velar and bilabial fricatives
> in Brahmi.
>
> Please review the patch.
> Thanks
Thanks, I installed this on the emacs-29 branch, and I'm closing the
bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#58957: [PATCH] Improve Brahmi composition rules.
2022-12-11 10:39 ` Eli Zaretskii
@ 2022-12-14 14:48 ` समीर सिंह Sameer Singh
2022-12-14 21:42 ` Stefan Kangas
0 siblings, 1 reply; 8+ messages in thread
From: समीर सिंह Sameer Singh @ 2022-12-14 14:48 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 58957-done
[-- Attachment #1: Type: text/plain, Size: 950 bytes --]
Thanks for installing!
Also sorry for not following up on the test idea and also the vertical text
input, I have started college from the past
month and am therefore finding it difficult to manage my time :'( . I
promise to return to them in the near future.
On Sun, Dec 11, 2022 at 4:09 PM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: समीर सिंह Sameer Singh
> > <lumarzeli30@gmail.com>
> > Date: Wed, 2 Nov 2022 08:14:09 +0530
> >
> > On Wed, Nov 2, 2022 at 8:12 AM समीर सिंह Sameer Singh <
> lumarzeli30@gmail.com> wrote:
> >
> > The present composition rules for Brahmi have a bug where the virama is
> not composed with the
> > consonants, I have fixed that now. I have also added support for
> composing velar and bilabial fricatives
> > in Brahmi.
> >
> > Please review the patch.
> > Thanks
>
> Thanks, I installed this on the emacs-29 branch, and I'm closing the
> bug.
>
[-- Attachment #2: Type: text/html, Size: 1463 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#58957: [PATCH] Improve Brahmi composition rules.
2022-12-14 14:48 ` समीर सिंह Sameer Singh
@ 2022-12-14 21:42 ` Stefan Kangas
0 siblings, 0 replies; 8+ messages in thread
From: Stefan Kangas @ 2022-12-14 21:42 UTC (permalink / raw)
To: समीर सिंह Sameer Singh,
Eli Zaretskii
Cc: 58957-done
समीर सिंह Sameer Singh <lumarzeli30@gmail.com> writes:
> Thanks for installing!
>
> Also sorry for not following up on the test idea and also the vertical text
> input, I have started college from the past
> month and am therefore finding it difficult to manage my time :'( . I
> promise to return to them in the near future.
Thanks for your work on Emacs.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-12-14 21:42 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-02 2:41 bug#58957: [PATCH] Improve Brahmi composition rules समीर सिंह Sameer Singh
2022-11-02 2:44 ` समीर सिंह Sameer Singh
2022-11-02 12:32 ` Eli Zaretskii
2022-11-02 14:57 ` समीर सिंह Sameer Singh
2022-11-24 19:40 ` Stefan Kangas
2022-12-11 10:39 ` Eli Zaretskii
2022-12-14 14:48 ` समीर सिंह Sameer Singh
2022-12-14 21:42 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).