From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?=E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0_?= =?UTF-8?Q?=E0=A4=B8=E0=A4=BF=E0=A4=82=E0=A4=B9?= Sameer Singh Newsgroups: gmane.emacs.bugs Subject: bug#58957: [PATCH] Improve Brahmi composition rules. Date: Wed, 2 Nov 2022 20:27:42 +0530 Message-ID: References: <834jvhbkqf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000adf1a205ec7e10a9" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31185"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58957@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 02 15:59:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqFDI-0007vz-HR for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Nov 2022 15:59:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqFCu-0008JN-9d; Wed, 02 Nov 2022 10:59:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqFCq-0008Ij-Tc for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 10:59:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqFCn-0003CC-Rz for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 10:59:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oqFCn-0007Ad-ND for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 10:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?=E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0_?= =?UTF-8?Q?=E0=A4=B8=E0=A4=BF=E0=A4=82=E0=A4=B9?= Sameer Singh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 14:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58957-submit@debbugs.gnu.org id=B58957.166740108227489 (code B ref 58957); Wed, 02 Nov 2022 14:59:01 +0000 Original-Received: (at 58957) by debbugs.gnu.org; 2 Nov 2022 14:58:02 +0000 Original-Received: from localhost ([127.0.0.1]:46964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqFBq-00079A-3b for submit@debbugs.gnu.org; Wed, 02 Nov 2022 10:58:02 -0400 Original-Received: from mail-yw1-f176.google.com ([209.85.128.176]:39649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqFBn-00078r-Nz for 58957@debbugs.gnu.org; Wed, 02 Nov 2022 10:58:00 -0400 Original-Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-36ad4cf9132so168686567b3.6 for <58957@debbugs.gnu.org>; Wed, 02 Nov 2022 07:57:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nWGEo0a6ULToqHipTZPVoZ8XCfby3W5XKyzRyfpeE0k=; b=kZ2sh0lvGdKPkR6hT/BUwcZK49IdqE24n2BIY5bCn+ESU9RdyehosJlUH1CdoSsSdn YHtCaBqkW8NpI7evC/CzDPOsyeiYUsGh/tmMBvZCUNjy2CDgnAXBJ43vN3+VNC/U98oN iO2Zww2ZxOHx3cmWCVlTM/ybEcaGPfLyEisgmXsk65ErNBh88mfBXmOn8LgNeaGNvJuG ne5mmHZK7Zt1cxK1ymUTFU9JgxQ3GvQzQW6jMNEuH7G26MI45/d2cyHFLiF8SXIZPuD1 8nqaDjcb9ms8g9ZypDfIeHyIGR79HjE5q/WH+PkQLo5pKxq/eWR3YDFNGhLJSPxMD+98 TpDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nWGEo0a6ULToqHipTZPVoZ8XCfby3W5XKyzRyfpeE0k=; b=fz38uybZH3WcBQigaOyyBArmGpCLBadZvFc1Et91BfldZ+NyGCUagfpqDNB4yeGAC3 K9qQSYKbLj8ry3xUYSD20yCDG+CJY+MiES41fdZQ/P97J24w1mldtBj3RGVLqlH/ORvI mpuqEUVeXrKMj7a2hVRFfEyqLIagy5IjrNqZcooTK9MJnutrCwVbKjvdmnlm6Zx6pf/M 6T0u7Q31d4YE0cJNVkB7IEln5OqHCDYJ5zT22nM0xKG5F9T6e+efOOPF6EIxsJPzCgJR QfmH/DbHQthGR/gkCWAttltJ1ahoroR0Y4gnhV3hPsswYlD4TORbXhLRima2GtIUabWM GUIg== X-Gm-Message-State: ACrzQf3UHQ4xfYTKUgAHfHFvEPP5SyIEYXYr374Q8CMZEKWR1WDxyybQ 2bvSCV8G9jQGDZRcT8qGVj1481ncE9H/GT8CSMmzeO/XMXE= X-Google-Smtp-Source: AMsMyM5S4bX6KF/goUHWl9Cg3571qK7h7Z6hZdPwEwCuH1dvjsxQrrbvbmTFTN+pypIBHbwW0/VduSPcSGP3utLNB2c= X-Received: by 2002:a0d:ea08:0:b0:36a:174c:4b1b with SMTP id t8-20020a0dea08000000b0036a174c4b1bmr23796005ywe.96.1667401073421; Wed, 02 Nov 2022 07:57:53 -0700 (PDT) In-Reply-To: <834jvhbkqf.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246876 Archived-At: --000000000000adf1a205ec7e10a9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > > Should we perhaps introduce tests for compositions? For example, I > guess you found the problems with the current rules by examining the > display of some sequences of characters, so why not add a test that > would make sure we never again break those composable sequences? Yes, that would be a good idea. How should I start? Are there some pre-existing examples that checks for composition, or even a manual that describes how to write a test? Thanks On Wed, Nov 2, 2022 at 6:02 PM Eli Zaretskii wrote: > > From: =E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0 =E0=A4=B8=E0=A4=BF=E0=A4=82= =E0=A4=B9 Sameer Singh > > > > Date: Wed, 2 Nov 2022 08:14:09 +0530 > > > > On Wed, Nov 2, 2022 at 8:12 AM =E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0 =E0= =A4=B8=E0=A4=BF=E0=A4=82=E0=A4=B9 Sameer Singh < > lumarzeli30@gmail.com> wrote: > > > > The present composition rules for Brahmi have a bug where the virama i= s > not composed with the > > consonants, I have fixed that now. I have also added support for > composing velar and bilabial fricatives in > > Brahmi. > > > > Please review the patch. > > Thanks. > > Should we perhaps introduce tests for compositions? For example, I > guess you found the problems with the current rules by examining the > display of some sequences of characters, so why not add a test that > would make sure we never again break those composable sequences? > --000000000000adf1a205ec7e10a9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Should w= e perhaps introduce tests for compositions?=C2=A0 For example, I
guess you found the problems with the current rules by examining the
display of some sequences of characters, so why not add a test that
would make sure we never again break those composable sequences?

Yes, that would be a good idea.
How should = I start? Are there some pre-existing examples that checks for composition,<= /div>
or even a manual that describes how to write a test?

Thanks

On Wed, Nov 2, 2022 at 6:02 PM Eli Zarets= kii <eliz@gnu.org> wrote:
> From: =E0=A4=B8=E0= =A4=AE=E0=A5=80=E0=A4=B0 =E0=A4=B8=E0=A4=BF=E0=A4=82=E0=A4=B9 Sameer Singh<= br> >=C2=A0 <l= umarzeli30@gmail.com>
> Date: Wed, 2 Nov 2022 08:14:09 +0530
>
> On Wed, Nov 2, 2022 at 8:12 AM =E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0 = =E0=A4=B8=E0=A4=BF=E0=A4=82=E0=A4=B9 Sameer Singh <lumarzeli30@gmail.com> wrote:<= br> >
>=C2=A0 The present composition rules for Brahmi have a bug where the vi= rama is not composed with the
>=C2=A0 consonants, I have fixed that now. I have also added support for= composing velar and bilabial fricatives in
>=C2=A0 Brahmi.
>
>=C2=A0 Please review the patch.

Thanks.

Should we perhaps introduce tests for compositions?=C2=A0 For example, I guess you found the problems with the current rules by examining the
display of some sequences of characters, so why not add a test that
would make sure we never again break those composable sequences?
--000000000000adf1a205ec7e10a9--